| Message ID | 1250610070-4122-1-git-send-email-lmr@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Nevermind the 3/4 header, this patch was on a branch I was doing other stuff. Already applied. On Tue, Aug 18, 2009 at 12:41 PM, Lucas Meneghel Rodrigues<lmr@redhat.com> wrote: > In order to extract more useful debugging information > from qemu crashes, pass --disable-strip to the configure > script so we produce binaries with debugging symbols. > > Also, corrected a small mistake on the calculation of > the -j make parameter. > > Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com> > --- > Â client/tests/kvm/kvm_install.py | Â Â 6 ++++-- > Â 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/client/tests/kvm/kvm_install.py b/client/tests/kvm/kvm_install.py > index 154b83c..35aff1d 100755 > --- a/client/tests/kvm/kvm_install.py > +++ b/client/tests/kvm/kvm_install.py > @@ -168,9 +168,11 @@ class SourceDirInstaller: > > Â Â def __build(self): > Â Â Â Â os.chdir(self.srcdir) > - Â Â Â Â cfg = "./configure --prefix=%s" % self.prefix > + Â Â Â Â # For testing purposes, it's better to build qemu binaries with > + Â Â Â Â # debugging symbols, so we can extract more meaningful stack traces. > + Â Â Â Â cfg = "./configure --disable-strip --prefix=%s" % self.prefix > Â Â Â Â if self.repo_type == 1: > - Â Â Â Â Â Â steps = [cfg, "make clean", "make -j %s" % utils.count_cpus()] > + Â Â Â Â Â Â steps = [cfg, "make clean", "make -j %s" % (utils.count_cpus() + 1)] > Â Â Â Â Â Â if not os.path.exists('qemu/pc-bios/bios.bin'): > Â Â Â Â Â Â Â Â steps.append("make -C bios") > Â Â Â Â Â Â Â Â steps.append("make -C extboot") > -- > 1.6.2.5 > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >
diff --git a/client/tests/kvm/kvm_install.py b/client/tests/kvm/kvm_install.py index 154b83c..35aff1d 100755 --- a/client/tests/kvm/kvm_install.py +++ b/client/tests/kvm/kvm_install.py @@ -168,9 +168,11 @@ class SourceDirInstaller: def __build(self): os.chdir(self.srcdir) - cfg = "./configure --prefix=%s" % self.prefix + # For testing purposes, it's better to build qemu binaries with + # debugging symbols, so we can extract more meaningful stack traces. + cfg = "./configure --disable-strip --prefix=%s" % self.prefix if self.repo_type == 1: - steps = [cfg, "make clean", "make -j %s" % utils.count_cpus()] + steps = [cfg, "make clean", "make -j %s" % (utils.count_cpus() + 1)] if not os.path.exists('qemu/pc-bios/bios.bin'): steps.append("make -C bios") steps.append("make -C extboot")
In order to extract more useful debugging information from qemu crashes, pass --disable-strip to the configure script so we produce binaries with debugging symbols. Also, corrected a small mistake on the calculation of the -j make parameter. Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com> --- client/tests/kvm/kvm_install.py | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)