KVM: Document KVM specific review items

Commit Message

Avi Kivity June 23, 2010, 8:38 a.m. UTC

None

Patch

diff --git a/Documentation/kvm/review-checklist.txt b/Documentation/kvm/review-checklist.txt
new file mode 100644
index 0000000..45ec18e
--- /dev/null
+++ b/Documentation/kvm/review-checklist.txt
@@ -0,0 +1,25 @@ 
+Review checklist for kvm patches
+================================
+
+1.  The patch must follow Documentation/CodingStyle and
+    Documentation/SubmittingPatches?
+
+2.  If the patch introduces or modifies a new userspace API:
+    - the API must be documented in Documentation/kvm/api.txt
+    - the API must be discoverable using KVM_CHECK_EXTENSION
+
+3.  New state must include support for save/restore.
+
+4.  New features must default to off (userspace should explicitly request them).
+    Performance improvements can and should default to on.
+
+5.  New cpu features should be exposed via KVM_GET_SUPPORTED_CPUID2
+
+6.  Emulator changes should be accompanied by unit tests for qemu-kvm.git
+    kvm/test directory.
+
+7.  Changes should be vendor neutral when possible.  Changes to common code
+    are better than duplicating changes to vendor code.
+
+8.  Similarly, prefer changes to arch independent code than to arch dependent
+    code.