From patchwork Wed Jun 23 08:38:34 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Avi Kivity <avi@redhat.com>
X-Patchwork-Id: 107563
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o5N8cddo015858
	for <patchwork-kvm@patchwork.kernel.org>;
	Wed, 23 Jun 2010 08:38:39 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751693Ab0FWIih (ORCPT
	<rfc822;patchwork-kvm@patchwork.kernel.org>);
	Wed, 23 Jun 2010 04:38:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48507 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751620Ab0FWIig (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 23 Jun 2010 04:38:36 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5N8caSN020582
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Wed, 23 Jun 2010 04:38:36 -0400
Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com
	[10.35.255.11])
	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with
	ESMTP id o5N8cZ2X031946
	for <kvm@vger.kernel.org>; Wed, 23 Jun 2010 04:38:35 -0400
Received: from file.tlv.redhat.com (file.tlv.redhat.com [10.35.255.8])
	by cleopatra.tlv.redhat.com (Postfix) with ESMTP id 10FE22500C5;
	Wed, 23 Jun 2010 11:38:35 +0300 (IDT)
From: Avi Kivity <avi@redhat.com>
To: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH] KVM: Document KVM specific review items
Date: Wed, 23 Jun 2010 11:38:34 +0300
Message-Id: <1277282314-23641-1-git-send-email-avi@redhat.com>
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21
Sender: kvm-owner@vger.kernel.org
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]);
	Wed, 23 Jun 2010 08:38:40 +0000 (UTC)


diff --git a/Documentation/kvm/review-checklist.txt b/Documentation/kvm/review-checklist.txt
new file mode 100644
index 0000000..45ec18e
--- /dev/null
+++ b/Documentation/kvm/review-checklist.txt
@@ -0,0 +1,25 @@
+Review checklist for kvm patches
+================================
+
+1.  The patch must follow Documentation/CodingStyle and
+    Documentation/SubmittingPatches?
+
+2.  If the patch introduces or modifies a new userspace API:
+    - the API must be documented in Documentation/kvm/api.txt
+    - the API must be discoverable using KVM_CHECK_EXTENSION
+
+3.  New state must include support for save/restore.
+
+4.  New features must default to off (userspace should explicitly request them).
+    Performance improvements can and should default to on.
+
+5.  New cpu features should be exposed via KVM_GET_SUPPORTED_CPUID2
+
+6.  Emulator changes should be accompanied by unit tests for qemu-kvm.git
+    kvm/test directory.
+
+7.  Changes should be vendor neutral when possible.  Changes to common code
+    are better than duplicating changes to vendor code.
+
+8.  Similarly, prefer changes to arch independent code than to arch dependent
+    code.