From patchwork Wed Jul  7 13:02:25 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jiri Slaby <jirislaby@gmail.com>
X-Patchwork-Id: 110634
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o67D3P9t029798
	for <patchwork-kvm@patchwork.kernel.org>; Wed, 7 Jul 2010 13:03:25 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753905Ab0GGNCq (ORCPT
	<rfc822;patchwork-kvm@patchwork.kernel.org>);
	Wed, 7 Jul 2010 09:02:46 -0400
Received: from mail.pripojeni.net ([217.66.174.14]:60582 "EHLO
	mail.pripojeni.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1753408Ab0GGNCp (ORCPT <rfc822; kvm@vger.kernel.org>);
	Wed, 7 Jul 2010 09:02:45 -0400
Received: from anemoi.localdomain ([217.66.174.142])
	by mail.pripojeni.net (Kerio Connect 7.0.0 patch 1);
	Wed, 7 Jul 2010 15:02:26 +0200
From: Jiri Slaby <jirislaby@gmail.com>
To: avi@redhat.com
Cc: jirislaby@gmail.com, linux-kernel@vger.kernel.org,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
	Gleb Natapov <gleb@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
	Gregory Haskins <ghaskins@novell.com>, kvm@vger.kernel.org
Subject: [PATCH] x86: KVM, fix lock imbalance
Date: Wed,  7 Jul 2010 15:02:25 +0200
Message-Id: <1278507745-32746-1-git-send-email-jirislaby@gmail.com>
X-Mailer: git-send-email 1.7.1
Sender: kvm-owner@vger.kernel.org
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]);
	Wed, 07 Jul 2010 13:03:26 +0000 (UTC)


diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
index 467cc47..70db4d4 100644
--- a/arch/x86/kvm/i8254.c
+++ b/arch/x86/kvm/i8254.c
@@ -696,6 +696,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
 
 	pit->wq = create_singlethread_workqueue("kvm-pit-wq");
 	if (!pit->wq) {
+		mutex_unlock(&pit->pit_state.lock);
 		kfree(pit);
 		return NULL;
 	}