From patchwork Sun Jul 11 22:56:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohammed Gamal X-Patchwork-Id: 111356 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o6BMuRh8026044 for ; Sun, 11 Jul 2010 22:57:23 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753765Ab0GKW4f (ORCPT ); Sun, 11 Jul 2010 18:56:35 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:38377 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063Ab0GKW4e (ORCPT ); Sun, 11 Jul 2010 18:56:34 -0400 Received: by wwi17 with SMTP id 17so256031wwi.1 for ; Sun, 11 Jul 2010 15:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=1tGbnSFcM+QUnhD1OM/sDBNjqokCqdATSYjNYU9tgb4=; b=Mop2VZju7gBEZMOCHLthAObake6HjwKkjFNsrTOfzISidicgPnT4a/UpljWTd+l8DE UaDMpUAXToKa6VJQaXOnS6pNUrYuDBlzqs4KpXvB0WXNzHLyeho4BW2SdnotCGsFxp9z Tr1Ud42THDnrjX6YtCGvrzdnDri6vIF5l2TQ4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=KnqzmCnIb+C59w0rnxHhBau4zvIZ3/PgpYDo6dXpm+2OoK+VlAP0KNXKjcld0XpzKw H9NUbFqGDvOSSfNFfVbu8GN5EIEhV+Aow5nl63PyBvu7+ajk7eugbLRawbkeDOhf8gXM /kEPso+p51JI3b1FcDSzIszqWXDJR0looGymI= Received: by 10.227.156.209 with SMTP id y17mr11896121wbw.18.1278888991847; Sun, 11 Jul 2010 15:56:31 -0700 (PDT) Received: from localhost ([41.238.118.224]) by mx.google.com with ESMTPS id a27sm25905222wbe.6.2010.07.11.15.56.29 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 11 Jul 2010 15:56:31 -0700 (PDT) From: Mohammed Gamal To: avi@redhat.com Cc: mtosatti@redhat.com, kvm@vger.kernel.org, Mohammed Gamal Subject: [RFC PATCH v3 1/3] Add helper methods to get segment limits Date: Mon, 12 Jul 2010 01:56:08 +0300 Message-Id: <1278888970-2936-2-git-send-email-m.gamal005@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1278888970-2936-1-git-send-email-m.gamal005@gmail.com> References: <1278888970-2936-1-git-send-email-m.gamal005@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Sun, 11 Jul 2010 22:57:26 +0000 (UTC) diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h index 51cfd73..ce90048 100644 --- a/arch/x86/include/asm/kvm_emulate.h +++ b/arch/x86/include/asm/kvm_emulate.h @@ -138,6 +138,7 @@ struct x86_emulate_ops { u16 (*get_segment_selector)(int seg, struct kvm_vcpu *vcpu); void (*set_segment_selector)(u16 sel, int seg, struct kvm_vcpu *vcpu); unsigned long (*get_cached_segment_base)(int seg, struct kvm_vcpu *vcpu); + u32 (*get_cached_segment_limit)(int seg, struct kvm_vcpu *vcpu); void (*get_gdt)(struct desc_ptr *dt, struct kvm_vcpu *vcpu); ulong (*get_cr)(int cr, struct kvm_vcpu *vcpu); int (*set_cr)(int cr, ulong val, struct kvm_vcpu *vcpu); diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 502e53f..e32efc4 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -468,6 +468,7 @@ struct kvm_x86_ops { int (*get_msr)(struct kvm_vcpu *vcpu, u32 msr_index, u64 *pdata); int (*set_msr)(struct kvm_vcpu *vcpu, u32 msr_index, u64 data); u64 (*get_segment_base)(struct kvm_vcpu *vcpu, int seg); + u32 (*get_segment_limit)(struct kvm_vcpu *vcpu, int seg); void (*get_segment)(struct kvm_vcpu *vcpu, struct kvm_segment *var, int seg); int (*get_cpl)(struct kvm_vcpu *vcpu); diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 56c9b6b..504761d 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -1038,6 +1038,13 @@ static u64 svm_get_segment_base(struct kvm_vcpu *vcpu, int seg) return s->base; } +static u32 svm_get_segment_limit(struct kvm_vcpu *vcpu, int seg) +{ + struct vmcb_seg *s = svm_seg(vcpu, seg); + + return s->limit; +} + static void svm_get_segment(struct kvm_vcpu *vcpu, struct kvm_segment *var, int seg) { @@ -3461,6 +3468,7 @@ static struct kvm_x86_ops svm_x86_ops = { .get_msr = svm_get_msr, .set_msr = svm_set_msr, .get_segment_base = svm_get_segment_base, + .get_segment_limit = svm_get_segment_limit, .get_segment = svm_get_segment, .set_segment = svm_set_segment, .get_cpl = svm_get_cpl, diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 2fdcc98..4e2626b 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -2001,6 +2001,13 @@ static u64 vmx_get_segment_base(struct kvm_vcpu *vcpu, int seg) return vmcs_readl(sf->base); } +static u32 vmx_get_segment_limit(struct kvm_vcpu *vcpu, int seg) +{ + struct kvm_vmx_segment_field *sf = &kvm_vmx_segment_fields[seg]; + + return vmcs_read32(sf->limit); +} + static void vmx_get_segment(struct kvm_vcpu *vcpu, struct kvm_segment *var, int seg) { @@ -4304,6 +4311,7 @@ static struct kvm_x86_ops vmx_x86_ops = { .get_msr = vmx_get_msr, .set_msr = vmx_set_msr, .get_segment_base = vmx_get_segment_base, + .get_segment_limit = vmx_get_segment_limit, .get_segment = vmx_get_segment, .set_segment = vmx_set_segment, .get_cpl = vmx_get_cpl, diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 6ed3176..23b9d2c 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3674,6 +3674,11 @@ static unsigned long get_segment_base(struct kvm_vcpu *vcpu, int seg) return kvm_x86_ops->get_segment_base(vcpu, seg); } +static u32 get_segment_limit (struct kvm_vcpu *vcpu, int seg) +{ + return kvm_x86_ops->get_segment_limit(vcpu, seg); +} + int emulate_invlpg(struct kvm_vcpu *vcpu, gva_t address) { kvm_mmu_invlpg(vcpu, address); @@ -3790,6 +3795,12 @@ static unsigned long emulator_get_cached_segment_base(int seg, return get_segment_base(vcpu, seg); } +static u32 emulator_get_cached_segment_limit(int seg, + struct kvm_vcpu *vcpu) +{ + return get_segment_limit(vcpu, seg); +} + static bool emulator_get_cached_descriptor(struct desc_struct *desc, int seg, struct kvm_vcpu *vcpu) { @@ -3876,6 +3887,7 @@ static struct x86_emulate_ops emulate_ops = { .get_segment_selector = emulator_get_segment_selector, .set_segment_selector = emulator_set_segment_selector, .get_cached_segment_base = emulator_get_cached_segment_base, + .get_cached_segment_limit = emulator_get_cached_segment_limit, .get_gdt = emulator_get_gdt, .get_cr = emulator_get_cr, .set_cr = emulator_set_cr,