From patchwork Thu Feb 24 07:28:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshiaki Tamura X-Patchwork-Id: 586681 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1O7crnO016680 for ; Thu, 24 Feb 2011 07:38:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944Ab1BXHip (ORCPT ); Thu, 24 Feb 2011 02:38:45 -0500 Received: from sh.osrg.net ([192.16.179.4]:55621 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753459Ab1BXHin (ORCPT ); Thu, 24 Feb 2011 02:38:43 -0500 Received: from fs.osrg.net (postfix@fs.osrg.net [10.0.0.12]) by sh.osrg.net (8.14.3/8.14.3/OSRG-NET) with ESMTP id p1O7bkj8026708; Thu, 24 Feb 2011 16:37:48 +0900 Received: from localhost (hype-nh0.osrg.net [10.72.1.48]) by fs.osrg.net (Postfix) with ESMTP id 437B73E0310; Thu, 24 Feb 2011 16:37:42 +0900 (JST) From: Yoshiaki Tamura To: kvm@vger.kernel.org, qemu-devel@nongnu.org Cc: avi@redhat.com, anthony@codemonkey.ws, aliguori@us.ibm.com, mtosatti@redhat.com, dlaor@redhat.com, mst@redhat.com, kwolf@redhat.com, pbonzini@redhat.com, quintela@redhat.com, ananth@in.ibm.com, psuriset@linux.vnet.ibm.com, vatsa@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp, Yoshiaki Tamura Subject: [PATCH 15/18] savevm: introduce qemu_savevm_trans_{begin,commit}. Date: Thu, 24 Feb 2011 16:28:41 +0900 Message-Id: <1298532524-1286-16-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> X-Mailer: git-send-email 1.7.1.2 In-Reply-To: <1298532524-1286-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> References: <1298532524-1286-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> X-Dispatcher: imput version 20070423(IM149) Lines: 247 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 24 Feb 2011 07:38:54 +0000 (UTC) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (sh.osrg.net [192.16.179.4]); Thu, 24 Feb 2011 16:37:48 +0900 (JST) X-Virus-Scanned: clamav-milter 0.96.5 at sh X-Virus-Status: Clean Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org diff --git a/savevm.c b/savevm.c index aa760b7..c21b901 100644 --- a/savevm.c +++ b/savevm.c @@ -1602,29 +1602,68 @@ bool qemu_savevm_state_blocked(Monitor *mon) return false; } -int qemu_savevm_state_begin(Monitor *mon, QEMUFile *f, int blk_enable, - int shared) +/* + * section: header to write + * inc: if true, forces to pass SECTION_PART instead of SECTION_START + * pause: if true, breaks the loop when live handler returned 0 + */ +static int qemu_savevm_state_live(Monitor *mon, QEMUFile *f, int section, + bool inc, bool pause) { SaveStateEntry *se; + int skip = 0, ret; QTAILQ_FOREACH(se, &savevm_handlers, entry) { - if(se->set_params == NULL) { + int len, stage; + + if (se->save_live_state == NULL) { continue; - } - se->set_params(blk_enable, shared, se->opaque); + } + + /* Section type */ + qemu_put_byte(f, section); + qemu_put_be32(f, se->section_id); + + if (section == QEMU_VM_SECTION_START) { + /* ID string */ + len = strlen(se->idstr); + qemu_put_byte(f, len); + qemu_put_buffer(f, (uint8_t *)se->idstr, len); + + qemu_put_be32(f, se->instance_id); + qemu_put_be32(f, se->version_id); + + stage = inc ? QEMU_VM_SECTION_PART : QEMU_VM_SECTION_START; + } else { + assert(inc); + stage = section; + } + + ret = se->save_live_state(mon, f, stage, se->opaque); + if (!ret) { + skip++; + if (pause) { + break; + } + } } - - qemu_put_be32(f, QEMU_VM_FILE_MAGIC); - qemu_put_be32(f, QEMU_VM_FILE_VERSION); + + return skip; +} + +static void qemu_savevm_state_full(QEMUFile *f) +{ + SaveStateEntry *se; QTAILQ_FOREACH(se, &savevm_handlers, entry) { int len; - if (se->save_live_state == NULL) + if (se->save_state == NULL && se->vmsd == NULL) { continue; + } /* Section type */ - qemu_put_byte(f, QEMU_VM_SECTION_START); + qemu_put_byte(f, QEMU_VM_SECTION_FULL); qemu_put_be32(f, se->section_id); /* ID string */ @@ -1635,9 +1674,29 @@ int qemu_savevm_state_begin(Monitor *mon, QEMUFile *f, int blk_enable, qemu_put_be32(f, se->instance_id); qemu_put_be32(f, se->version_id); - se->save_live_state(mon, f, QEMU_VM_SECTION_START, se->opaque); + vmstate_save(f, se); + } + + qemu_put_byte(f, QEMU_VM_EOF); +} + +int qemu_savevm_state_begin(Monitor *mon, QEMUFile *f, int blk_enable, + int shared) +{ + SaveStateEntry *se; + + QTAILQ_FOREACH(se, &savevm_handlers, entry) { + if (se->set_params == NULL) { + continue; + } + se->set_params(blk_enable, shared, se->opaque); } + qemu_put_be32(f, QEMU_VM_FILE_MAGIC); + qemu_put_be32(f, QEMU_VM_FILE_VERSION); + + qemu_savevm_state_live(mon, f, QEMU_VM_SECTION_START, 0, 0); + if (qemu_file_has_error(f)) { qemu_savevm_state_cancel(mon, f); return -EIO; @@ -1648,29 +1707,16 @@ int qemu_savevm_state_begin(Monitor *mon, QEMUFile *f, int blk_enable, int qemu_savevm_state_iterate(Monitor *mon, QEMUFile *f) { - SaveStateEntry *se; int ret = 1; - QTAILQ_FOREACH(se, &savevm_handlers, entry) { - if (se->save_live_state == NULL) - continue; - - /* Section type */ - qemu_put_byte(f, QEMU_VM_SECTION_PART); - qemu_put_be32(f, se->section_id); - - ret = se->save_live_state(mon, f, QEMU_VM_SECTION_PART, se->opaque); - if (!ret) { - /* Do not proceed to the next vmstate before this one reported - completion of the current stage. This serializes the migration - and reduces the probability that a faster changing state is - synchronized over and over again. */ - break; - } - } - - if (ret) + /* Do not proceed to the next vmstate before this one reported + completion of the current stage. This serializes the migration + and reduces the probability that a faster changing state is + synchronized over and over again. */ + ret = qemu_savevm_state_live(mon, f, QEMU_VM_SECTION_PART, 1, 1); + if (!ret) { return 1; + } if (qemu_file_has_error(f)) { qemu_savevm_state_cancel(mon, f); @@ -1682,46 +1728,41 @@ int qemu_savevm_state_iterate(Monitor *mon, QEMUFile *f) int qemu_savevm_state_complete(Monitor *mon, QEMUFile *f) { - SaveStateEntry *se; - cpu_synchronize_all_states(); - QTAILQ_FOREACH(se, &savevm_handlers, entry) { - if (se->save_live_state == NULL) - continue; - - /* Section type */ - qemu_put_byte(f, QEMU_VM_SECTION_END); - qemu_put_be32(f, se->section_id); + qemu_savevm_state_live(mon, f, QEMU_VM_SECTION_END, 1, 0); + qemu_savevm_state_full(f); - se->save_live_state(mon, f, QEMU_VM_SECTION_END, se->opaque); + if (qemu_file_has_error(f)) { + return -EIO; } - QTAILQ_FOREACH(se, &savevm_handlers, entry) { - int len; + return 0; +} - if (se->save_state == NULL && se->vmsd == NULL) - continue; +int qemu_savevm_trans_begin(Monitor *mon, QEMUFile *f, int init) +{ + int ret; - /* Section type */ - qemu_put_byte(f, QEMU_VM_SECTION_FULL); - qemu_put_be32(f, se->section_id); + ret = qemu_savevm_state_live(mon, f, QEMU_VM_SECTION_START, !init, 0); - /* ID string */ - len = strlen(se->idstr); - qemu_put_byte(f, len); - qemu_put_buffer(f, (uint8_t *)se->idstr, len); + if (qemu_file_has_error(f)) { + return -EIO; + } - qemu_put_be32(f, se->instance_id); - qemu_put_be32(f, se->version_id); + return ret; +} - vmstate_save(f, se); - } +int qemu_savevm_trans_complete(Monitor *mon, QEMUFile *f) +{ + cpu_synchronize_all_states(); - qemu_put_byte(f, QEMU_VM_EOF); + qemu_savevm_state_live(mon, f, QEMU_VM_SECTION_PART, 1, 0); + qemu_savevm_state_full(f); - if (qemu_file_has_error(f)) + if (qemu_file_has_error(f)) { return -EIO; + } return 0; } diff --git a/sysemu.h b/sysemu.h index 0a83ab9..4c38972 100644 --- a/sysemu.h +++ b/sysemu.h @@ -93,6 +93,8 @@ int qemu_savevm_state_begin(Monitor *mon, QEMUFile *f, int blk_enable, int qemu_savevm_state_iterate(Monitor *mon, QEMUFile *f); int qemu_savevm_state_complete(Monitor *mon, QEMUFile *f); void qemu_savevm_state_cancel(Monitor *mon, QEMUFile *f); +int qemu_savevm_trans_begin(Monitor *mon, QEMUFile *f, int init); +int qemu_savevm_trans_complete(Monitor *mon, QEMUFile *f); int qemu_loadvm_state(QEMUFile *f); /* SLIRP */