Message ID | 1302950696-12806-1-git-send-email-prasadjoshi124@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
* Prasad Joshi <prasadjoshi124@gmail.com> wrote: > Include the Linux kernel header file linux/stringify.h file instead of > redefining the __stringify* macros > > Signed-off-by: Prasad Joshi <prasadjoshi124@gmail.com> Small title nit, please do something like: - Remove the __stringify*() defination from the util.h + Remove the __stringify*() definitions from util.h Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/kvm/include/kvm/util.h b/tools/kvm/include/kvm/util.h index ae033cc..fc222c3 100644 --- a/tools/kvm/include/kvm/util.h +++ b/tools/kvm/include/kvm/util.h @@ -1,3 +1,5 @@ +#include <linux/stringify.h> + #ifndef KVM__UTIL_H #define KVM__UTIL_H @@ -27,9 +29,6 @@ #endif #endif -#define __stringify_1(x) #x -#define __stringify(x) __stringify_1(x) - extern void die(const char *err, ...) NORETURN __attribute__((format (printf, 1, 2))); extern void die_perror(const char *s) NORETURN; extern int error(const char *err, ...) __attribute__((format (printf, 1, 2)));
Include the Linux kernel header file linux/stringify.h file instead of redefining the __stringify* macros Signed-off-by: Prasad Joshi <prasadjoshi124@gmail.com> --- tools/kvm/include/kvm/util.h | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)