| Message ID | 1305136906-14496-1-git-send-email-penberg@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/12/2011 02:01 AM, Pekka Enberg wrote: > This patch changes the '-c' command line option to specify the number of CPUs > because it's used more often than console switching. I'd like to tune the command line option further. 1) Change -i, --image <image> Disk image to -d, --disk <disk> Disk image 2) Change -r, --initrd <initrd> Initial RAM disk image to -i, --initrd <initrd> Initial RAM disk image 3) Change -d, --kvm-dev <kvm-dev> KVM device file -s, --single-step Enable single stepping -g, --ioport-debug Enable ioport debugging to --kvm-dev <kvm-dev> KVM device file --single-step Enable single stepping --ioport-debug Enable ioport debugging . So we can have -c --cpus -m --mem -d --disk -k --kernel -i --initrd which is more consistent and easy to remember.
* Asias He <asias.hejun@gmail.com> wrote: > On 05/12/2011 02:01 AM, Pekka Enberg wrote: > > This patch changes the '-c' command line option to specify the number of CPUs > > because it's used more often than console switching. > > I'd like to tune the command line option further. > > 1) > Change > -i, --image <image> Disk image > to > -d, --disk <disk> Disk image Agreed. > 2) > Change > -r, --initrd <initrd> > Initial RAM disk image > to > -i, --initrd <initrd> > Initial RAM disk image Agreed. > 3) > Change > -d, --kvm-dev <kvm-dev> > KVM device file > -s, --single-step Enable single stepping > -g, --ioport-debug Enable ioport debugging > to > --kvm-dev <kvm-dev> > KVM device file > --single-step Enable single stepping > --ioport-debug Enable ioport debugging Yeah, it would be nice to free up -d, -s, -g. The debug options should probably be concentrated under a --debug option anyway, to allow things like: --debug single-step,ioport Even if the debug options are kept they should be streamlined along the same pattern: > --debug-single-step Enable single stepping > --debug-ioport Enable ioport debugging But having a --debug option that recognizes all the debug flags would be nicer. It would also allow future enhancements to group debug features, like: --debug all # turn on everything and the kitchen sink for early hangs --debug all,-single-step # turn on everything except single-step debugging --debug nonverbose # turn on all non-noisy debug options we have Maybe even: --debug memcheck ... could run kvm under valgrind automatically - that way we can hide any secondary tool complexities from the user and turn those tools into simple debug options :-) etc. > So we can have > -c --cpus > -m --mem > -d --disk > -k --kernel > -i --initrd > which is more consistent and easy to remember. Very nice plans! The sooner we do this the fewer people will have to change their scripts and practices. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/12/2011 03:17 PM, Ingo Molnar wrote: > > * Asias He <asias.hejun@gmail.com> wrote: > >> On 05/12/2011 02:01 AM, Pekka Enberg wrote: >>> This patch changes the '-c' command line option to specify the number of CPUs >>> because it's used more often than console switching. >> >> I'd like to tune the command line option further. >> >> 1) >> Change >> -i, --image <image> Disk image >> to >> -d, --disk <disk> Disk image > > Agreed. > >> 2) >> Change >> -r, --initrd <initrd> >> Initial RAM disk image >> to >> -i, --initrd <initrd> >> Initial RAM disk image > > Agreed. > >> 3) >> Change >> -d, --kvm-dev <kvm-dev> >> KVM device file >> -s, --single-step Enable single stepping >> -g, --ioport-debug Enable ioport debugging >> to >> --kvm-dev <kvm-dev> >> KVM device file >> --single-step Enable single stepping >> --ioport-debug Enable ioport debugging > > Yeah, it would be nice to free up -d, -s, -g. > > The debug options should probably be concentrated under a --debug option > anyway, to allow things like: > > --debug single-step,ioport > > Even if the debug options are kept they should be streamlined along the same > pattern: > >> --debug-single-step Enable single stepping >> --debug-ioport Enable ioport debugging > > But having a --debug option that recognizes all the debug flags would be nicer. > > It would also allow future enhancements to group debug features, like: > > --debug all # turn on everything and the kitchen sink for early hangs > --debug all,-single-step # turn on everything except single-step debugging > --debug nonverbose # turn on all non-noisy debug options we have > > Maybe even: > > --debug memcheck > > ... could run kvm under valgrind automatically - that way we can hide any > secondary tool complexities from the user and turn those tools into simple > debug options :-) Great idea. > > etc. > >> So we can have >> -c --cpus >> -m --mem >> -d --disk >> -k --kernel >> -i --initrd >> which is more consistent and easy to remember. > > Very nice plans! > > The sooner we do this the fewer people will have to change their scripts and > practices. Sure! I will cook a patch.
diff --git a/tools/kvm/kvm-run.c b/tools/kvm/kvm-run.c index 829b33f..9b5176f 100644 --- a/tools/kvm/kvm-run.c +++ b/tools/kvm/kvm-run.c @@ -97,10 +97,10 @@ static int img_name_parser(const struct option *opt, const char *arg, int unset) static const struct option options[] = { OPT_GROUP("Basic options:"), - OPT_INTEGER('\0', "cpus", &nrcpus, "Number of CPUs"), + OPT_INTEGER('c', "cpus", &nrcpus, "Number of CPUs"), OPT_U64('m', "mem", &ram_size, "Virtual machine memory size in MiB."), OPT_CALLBACK('i', "image", NULL, "image", "Disk image", img_name_parser), - OPT_STRING('c', "console", &console, "serial or virtio", + OPT_STRING('\0', "console", &console, "serial or virtio", "Console to use"), OPT_BOOLEAN('\0', "virtio-rng", &virtio_rng, "Enable virtio Random Number Generator"),
This patch changes the '-c' command line option to specify the number of CPUs because it's used more often than console switching. Cc: Asias He <asias.hejun@gmail.com> Cc: Avi Kivity <avi@redhat.com> Cc: Cyrill Gorcunov <gorcunov@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Prasad Joshi <prasadjoshi124@gmail.com> Cc: Sasha Levin <levinsasha928@gmail.com> Signed-off-by: Pekka Enberg <penberg@kernel.org> --- tools/kvm/kvm-run.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)