diff mbox

[01/14] kvm tools: Move disk image related code under disk directory

Message ID 1305706755-2816-1-git-send-email-asias.hejun@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Asias He May 18, 2011, 8:19 a.m. UTC
This patch removes disk-image.c and qcow.c under disk directory.

Signed-off-by: Asias He <asias.hejun@gmail.com>
---
 tools/kvm/Makefile                |    4 ++--
 tools/kvm/{ => disk}/disk-image.c |    0
 tools/kvm/{ => disk}/qcow.c       |    0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename tools/kvm/{ => disk}/disk-image.c (100%)
 rename tools/kvm/{ => disk}/qcow.c (100%)

diff --git a/tools/kvm/disk-image.c b/tools/kvm/disk/disk-image.c
similarity index 100%
rename from tools/kvm/disk-image.c
rename to tools/kvm/disk/disk-image.c
diff --git a/tools/kvm/qcow.c b/tools/kvm/disk/qcow.c
similarity index 100%
rename from tools/kvm/qcow.c
rename to tools/kvm/disk/qcow.c

Comments

Ingo Molnar May 18, 2011, 8:42 a.m. UTC | #1
* Asias He <asias.hejun@gmail.com> wrote:

> This patch removes disk-image.c and qcow.c under disk directory.
> 
> Signed-off-by: Asias He <asias.hejun@gmail.com>
> ---
>  tools/kvm/Makefile                |    4 ++--
>  tools/kvm/{ => disk}/disk-image.c |    0

btw., you may want to name it 'image.c' and thus have the intuitive:

 tools/kvm/disk-image.c =>
 tools/kvm/disk/image.c 

replacement instead of tools/kvm/disk/disk-image.c which repeats 'disk' twice.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ingo Molnar May 18, 2011, 8:43 a.m. UTC | #2
* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Asias He <asias.hejun@gmail.com> wrote:
> 
> > This patch removes disk-image.c and qcow.c under disk directory.
> > 
> > Signed-off-by: Asias He <asias.hejun@gmail.com>
> > ---
> >  tools/kvm/Makefile                |    4 ++--
> >  tools/kvm/{ => disk}/disk-image.c |    0
> 
> btw., you may want to name it 'image.c' and thus have the intuitive:
> 
>  tools/kvm/disk-image.c =>
>  tools/kvm/disk/image.c 
> 
> replacement instead of tools/kvm/disk/disk-image.c which repeats 'disk' twice.

oh, stupid me: you rename it to core.c in patch #2!

I should really do what i do normally, read patch series from the end backwards 
;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile
index 45897d5..8938f5f 100644
--- a/tools/kvm/Makefile
+++ b/tools/kvm/Makefile
@@ -15,7 +15,7 @@  TAGS = ctags
 OBJS	+= 8250-serial.o
 OBJS	+= cpuid.o
 OBJS	+= read-write.o
-OBJS	+= disk-image.o
+OBJS	+= disk/disk-image.o
 OBJS	+= interrupt.o
 OBJS	+= ioport.o
 OBJS	+= kvm.o
@@ -37,7 +37,7 @@  OBJS    += util/strbuf.o
 OBJS    += kvm-help.o
 OBJS    += kvm-cmd.o
 OBJS    += kvm-run.o
-OBJS    += qcow.o
+OBJS    += disk/qcow.o
 OBJS    += mptable.o
 OBJS    += threadpool.o
 OBJS    += irq.o