From patchwork Wed Dec 12 05:05:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Yang Z" X-Patchwork-Id: 1864601 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6FDA8DF2EE for ; Wed, 12 Dec 2012 05:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750834Ab2LLFJm (ORCPT ); Wed, 12 Dec 2012 00:09:42 -0500 Received: from mga14.intel.com ([143.182.124.37]:64036 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790Ab2LLFJl (ORCPT ); Wed, 12 Dec 2012 00:09:41 -0500 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 11 Dec 2012 21:09:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,264,1355126400"; d="scan'208";a="230304197" Received: from yang-desktop.sh.intel.com ([10.239.13.107]) by azsmga001.ch.intel.com with ESMTP; 11 Dec 2012 21:09:36 -0800 From: Yang Zhang To: kvm@vger.kernel.org Cc: gleb@redhat.com, Yang Zhang Subject: [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0 Date: Wed, 12 Dec 2012 13:05:12 +0800 Message-Id: <1355288712-26899-1-git-send-email-yang.z.zhang@intel.com> X-Mailer: git-send-email 1.7.1.1 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Yang Zhang This hack is wrong. The pin number of PIT is connected to 2 not 0. This means this hack never takes effect. So it is ok to remove it. Signed-off-by: Yang Zhang Acked-by: Gleb Natapov --- virt/kvm/ioapic.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index cfb7e4d..f3abbef 100644 --- a/virt/kvm/ioapic.c +++ b/virt/kvm/ioapic.c @@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq) irqe.level = 1; irqe.shorthand = 0; -#ifdef CONFIG_X86 - /* Always delivery PIT interrupt to vcpu 0 */ - if (irq == 0) { - irqe.dest_mode = 0; /* Physical mode. */ - /* need to read apic_id from apic regiest since - * it can be rewritten */ - irqe.dest_id = ioapic->kvm->bsp_vcpu_id; - } -#endif return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe); }