From patchwork Sun May 19 04:52:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nakajima, Jun" X-Patchwork-Id: 2589711 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 815A8DF24C for ; Sun, 19 May 2013 04:53:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751769Ab3ESEwz (ORCPT ); Sun, 19 May 2013 00:52:55 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:51691 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219Ab3ESEwy (ORCPT ); Sun, 19 May 2013 00:52:54 -0400 Received: by mail-pb0-f48.google.com with SMTP id md12so1722587pbc.7 for ; Sat, 18 May 2013 21:52:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=EHiUn7XwPqJhl1wgDLYDrlGIgtxofQ5w1M13gOqdM24=; b=HBeV6Ag+Da8GBY0tAXfZjjBbOd/LJ5TeqIUdkCzlykNBMipV76oIqrj7/7MhUosl5I zGejg19Dn+9trCAPnG/Fe6KfI8R7GUdLfq2+sMwDBApoOn8fbKzoCojXhWcIVyhycv+I byBGVtHC6FsV3YzodmPzTOyTTqKA3Ej2UElhNgtYbf0LLeRZZMntzqXNInCxdXrSJMey snpOgR+bV44dI5ZtIFVt2pXkxRznIi/AtYZ6vAwX8JmAA9OEDlhFKnTYAWnZ80fQFPD4 Lgb5faDtKctOd92PpQ3M/oydzggi21SzdQgUHq9Ey3x8CPpZa5LqSCl533CG8qxYaeGK hCoQ== X-Received: by 10.66.154.167 with SMTP id vp7mr55437267pab.7.1368939173438; Sat, 18 May 2013 21:52:53 -0700 (PDT) Received: from localhost (c-98-207-34-191.hsd1.ca.comcast.net. [98.207.34.191]) by mx.google.com with ESMTPSA id v7sm18199763pbq.32.2013.05.18.21.52.51 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 18 May 2013 21:52:52 -0700 (PDT) From: Jun Nakajima To: kvm@vger.kernel.org Cc: Gleb Natapov , Paolo Bonzini Subject: [PATCH v3 08/13] nEPT: Some additional comments Date: Sat, 18 May 2013 21:52:27 -0700 Message-Id: <1368939152-11406-8-git-send-email-jun.nakajima@intel.com> X-Mailer: git-send-email 1.8.2.1.610.g562af5b In-Reply-To: <1368939152-11406-1-git-send-email-jun.nakajima@intel.com> References: <1368939152-11406-1-git-send-email-jun.nakajima@intel.com> X-Gm-Message-State: ALoCoQn/lxr2/+O928SrBLeqPB01/ONh8Ve6eveAqOHs03ug+dhGSiFSBlXzAgwVGrThZfBUAL8Z Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Nadav Har'El Some additional comments to preexisting code: Explain who (L0 or L1) handles EPT violation and misconfiguration exits. Don't mention "shadow on either EPT or shadow" as the only two options. Signed-off-by: Nadav Har'El Signed-off-by: Jun Nakajima Signed-off-by: Xinhao Xu Reviewed-by: Paolo Bonzini --- arch/x86/kvm/vmx.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index b79efd4..4661a22 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -6540,7 +6540,20 @@ static bool nested_vmx_exit_handled(struct kvm_vcpu *vcpu) return nested_cpu_has2(vmcs12, SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES); case EXIT_REASON_EPT_VIOLATION: + /* + * L0 always deals with the EPT violation. If nested EPT is + * used, and the nested mmu code discovers that the address is + * missing in the guest EPT table (EPT12), the EPT violation + * will be injected with nested_ept_inject_page_fault() + */ + return 0; case EXIT_REASON_EPT_MISCONFIG: + /* + * L2 never uses directly L1's EPT, but rather L0's own EPT + * table (shadow on EPT) or a merged EPT table that L0 built + * (EPT on EPT). So any problems with the structure of the + * table is L0's fault. + */ return 0; case EXIT_REASON_PREEMPTION_TIMER: return vmcs12->pin_based_vm_exec_control &