From patchwork Mon May 5 01:28:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 4111361 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9283EBFF02 for ; Mon, 5 May 2014 01:28:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BB81E2037A for ; Mon, 5 May 2014 01:28:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D380D20254 for ; Mon, 5 May 2014 01:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbaEEB2k (ORCPT ); Sun, 4 May 2014 21:28:40 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:55037 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754082AbaEEB2D (ORCPT ); Sun, 4 May 2014 21:28:03 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 5 May 2014 11:28:01 +1000 Received: from d23dlp02.au.ibm.com (202.81.31.213) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 5 May 2014 11:27:59 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 2990C2BB0055; Mon, 5 May 2014 11:27:59 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s451RitD11338220; Mon, 5 May 2014 11:27:44 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s451RwrK011593; Mon, 5 May 2014 11:27:58 +1000 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.190.163.12]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s451RwX1011588; Mon, 5 May 2014 11:27:58 +1000 Received: from shangw (haven.au.ibm.com [9.190.164.82]) by ozlabs.au.ibm.com (Postfix) with ESMTP id D955EA0117; Mon, 5 May 2014 11:27:57 +1000 (EST) Received: by shangw (Postfix, from userid 1000) id C8EF53E0370; Mon, 5 May 2014 11:28:19 +1000 (EST) From: Gavin Shan To: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Cc: alex.williamson@redhat.com, benh@kernel.crashing.org, aik@ozlabs.ru, qiudayu@linux.vnet.ibm.com, Gavin Shan Subject: [PATCH 15/22] powerpc/eeh: Emulate RTAS call ibm,slot-error-detail Date: Mon, 5 May 2014 11:28:04 +1000 Message-Id: <1399253291-3975-16-git-send-email-gwshan@linux.vnet.ibm.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1399253291-3975-1-git-send-email-gwshan@linux.vnet.ibm.com> References: <1399253291-3975-1-git-send-email-gwshan@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14050501-5140-0000-0000-0000050CCCF2 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The RTAS call "ibm,slot-error-detail" is being used to retrieve the error log (either permanent or temporary) from the underlying firmware. The patch implements the backend to emulate the RTAS call. Signed-off-by: Gavin Shan --- arch/powerpc/platforms/powernv/eeh-rtas.c | 75 +++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/arch/powerpc/platforms/powernv/eeh-rtas.c b/arch/powerpc/platforms/powernv/eeh-rtas.c index 4a9c2c7..8934564 100644 --- a/arch/powerpc/platforms/powernv/eeh-rtas.c +++ b/arch/powerpc/platforms/powernv/eeh-rtas.c @@ -390,6 +390,78 @@ out: return ret; } +static int kvmppc_eeh_get_error(struct kvm_vcpu *vcpu, + struct rtas_args *args) +{ + struct pci_controller *hose; + struct pnv_phb *phb; + struct eeh_dev *edev; + struct eeh_pe *pe; + struct eeh_vfio_pci_addr addr; + char *log; + int guest_log; + int len, severity; + int ret = 0; + + /* Sanity check on parameter */ + if (args->nargs != 8 || args->nret != 1) { + pr_warn("%s: Non-matched arguments (%d, %d) - (8, 1)\n", + __func__, args->nargs, args->nret); + ret = 1; + goto out; + } else if (args->args[7] != 1 && args->args[7] != 2) { + pr_warn("%s: Invalid Log type\n", __func__); + ret = 1; + goto out; + } + + /* Figure out the address */ + if (kvmppc_eeh_format_addr(vcpu, args, &addr, false, &edev, &pe)) { + ret = 1; + goto out; + } + + /* Make sure that the EEH stuff has been initialized */ + hose = pe->phb; + phb = hose->private_data; + if (!(phb->flags & PNV_PHB_FLAG_EEH)) { + pr_warn("%s: EEH disabled on PHB#%d\n", + __func__, hose->global_number); + ret = 1; + goto out; + } + + /* + * Retrieve error log from PE. We don't have cached error + * log for one specific PE yet, which need to be figured + * out later. + */ + if (phb->eeh_ops && phb->eeh_ops->get_log) { + guest_log = args->args[5]; + len = args->args[6]; + severity = args->args[7]; + log = kzalloc(len, GFP_KERNEL); + if (!log) { + pr_err("%s: Out of memory!\n", __func__); + ret = 1; + goto out; + } + + phb->eeh_ops->get_log(pe, severity, log, len); + if (kvm_write_guest(vcpu->kvm, guest_log, log, len)) { + pr_warn("%s: Fail pushing log to guest\n", + __func__); + ret = 1; + } + + kfree(log); + } else { + ret = 1; + } +out: + return ret; +} + /** * kvmppc_eeh_rtas - Backend for EEH RTAS emulation * @vcpu: KVM virtual CPU @@ -418,6 +490,9 @@ void kvmppc_eeh_rtas(struct kvm_vcpu *vcpu, struct rtas_args *args, int op) case eeh_rtas_get_config_addr_info2: ret = kvmppc_eeh_get_addr2(vcpu, args); break; + case eeh_rtas_slot_error_detail: + ret = kvmppc_eeh_get_error(vcpu, args); + break; default: pr_warn("%s: Unsupported EEH RTAS service#%d\n", __func__, op);