| Message ID | 1439563931-12352-6-git-send-email-guangrong.xiao@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 14 Aug 2015 22:51:58 +0800 Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote: > Implement CreateField term which are used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> > --- > hw/acpi/aml-build.c | 14 ++++++++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 15 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index a526eed..debdad2 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -1151,6 +1151,20 @@ Aml *aml_sizeof(Aml *arg) > return var; > } > > +/* ACPI 6.0: 20.2.5.2 Named Objects Encoding: DefCreateField */ ditto, refer to to the first revision where it's appeared > +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name) index and len could be only of 'Integer' type, so there is no point to pass them in as Aml, just use uintFOO_t here and convert them to aml_int() internally. That way call sites will be smaller and have less chance to pass a wrong Aml variable. > +{ > + Aml *var = aml_alloc(); > + drop newline > + build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */ > + build_append_byte(var->buf, 0x13); /* CreateFieldOp */ > + aml_append(var, srcbuf); > + aml_append(var, index); > + aml_append(var, len); > + build_append_namestring(var->buf, "%s", name); > + return var; > +} > + > void > build_header(GArray *linker, GArray *table_data, > AcpiTableHeader *h, const char *sig, int len, uint8_t rev) > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 6b591ab..d4dbd44 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -277,6 +277,7 @@ Aml *aml_touuid(const char *uuid); > Aml *aml_unicode(const char *str); > Aml *aml_derefof(Aml *arg); > Aml *aml_sizeof(Aml *arg); > +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name); > > void > build_header(GArray *linker, GArray *table_data, -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/02/2015 07:10 PM, Igor Mammedov wrote: > On Fri, 14 Aug 2015 22:51:58 +0800 > Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote: > >> Implement CreateField term which are used by NVDIMM _DSM method in later patch >> >> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> >> --- >> hw/acpi/aml-build.c | 14 ++++++++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 15 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index a526eed..debdad2 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -1151,6 +1151,20 @@ Aml *aml_sizeof(Aml *arg) >> return var; >> } >> >> +/* ACPI 6.0: 20.2.5.2 Named Objects Encoding: DefCreateField */ > ditto, refer to to the first revision where it's appeared Well do it. > >> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name) > index and len could be only of 'Integer' type, so there is no point > to pass them in as Aml, just use uintFOO_t here and convert > them to aml_int() internally. That way call sites will be smaller > and have less chance to pass a wrong Aml variable. > Good idea. BTW, Igor, sorry for the delay reply since we got a holiday in this week. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index a526eed..debdad2 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -1151,6 +1151,20 @@ Aml *aml_sizeof(Aml *arg) return var; } +/* ACPI 6.0: 20.2.5.2 Named Objects Encoding: DefCreateField */ +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name) +{ + Aml *var = aml_alloc(); + + build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */ + build_append_byte(var->buf, 0x13); /* CreateFieldOp */ + aml_append(var, srcbuf); + aml_append(var, index); + aml_append(var, len); + build_append_namestring(var->buf, "%s", name); + return var; +} + void build_header(GArray *linker, GArray *table_data, AcpiTableHeader *h, const char *sig, int len, uint8_t rev) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index 6b591ab..d4dbd44 100644 --- a/include/hw/acpi/aml-build.h +++ b/include/hw/acpi/aml-build.h @@ -277,6 +277,7 @@ Aml *aml_touuid(const char *uuid); Aml *aml_unicode(const char *str); Aml *aml_derefof(Aml *arg); Aml *aml_sizeof(Aml *arg); +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name); void build_header(GArray *linker, GArray *table_data,
Implement CreateField term which are used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> --- hw/acpi/aml-build.c | 14 ++++++++++++++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 15 insertions(+)