| Message ID | 1454353431-13618-1-git-send-email-pfeiner@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 1, 2016 at 11:03 AM, Peter Feiner <pfeiner@google.com> wrote: > Typo lead to confusing code. The s3 test was writing the contents of > address 0 to the output port, not explicitly the number zero! > > Signed-off-by: Peter Feiner <pfeiner@google.com> > --- > x86/s3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86/s3.c b/x86/s3.c > index 8bf71da..c7d78c1 100644 > --- a/x86/s3.c > +++ b/x86/s3.c > @@ -73,7 +73,7 @@ asm ( > ".global resume_end\n" > ".code16\n" > "resume_start:\n" > - "mov 0x0, %eax\n" > + "mov $0x0, %eax\n" > "mov $0xf4, %dx\n" > "out %eax, %dx\n" > "1: hlt\n" > -- > 2.7.0.rc3.207.g0ac5344 > Nevermind. It's suppose to read *0, hence the *0 = 1 in the while loop. Please ignore :-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/x86/s3.c b/x86/s3.c index 8bf71da..c7d78c1 100644 --- a/x86/s3.c +++ b/x86/s3.c @@ -73,7 +73,7 @@ asm ( ".global resume_end\n" ".code16\n" "resume_start:\n" - "mov 0x0, %eax\n" + "mov $0x0, %eax\n" "mov $0xf4, %dx\n" "out %eax, %dx\n" "1: hlt\n"
Typo lead to confusing code. The s3 test was writing the contents of address 0 to the output port, not explicitly the number zero! Signed-off-by: Peter Feiner <pfeiner@google.com> --- x86/s3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)