From patchwork Mon Feb 22 23:35:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Feiner X-Patchwork-Id: 8385241 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A1591C0553 for ; Mon, 22 Feb 2016 23:35:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D5DD120606 for ; Mon, 22 Feb 2016 23:35:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F51820613 for ; Mon, 22 Feb 2016 23:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756360AbcBVXfM (ORCPT ); Mon, 22 Feb 2016 18:35:12 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33786 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756221AbcBVXfJ (ORCPT ); Mon, 22 Feb 2016 18:35:09 -0500 Received: by mail-pa0-f49.google.com with SMTP id fl4so98972667pad.0 for ; Mon, 22 Feb 2016 15:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=5i/D5TieuUrhJvVB+CfP7tSnYyWSWzLsRDk97jx831A=; b=gcfnW1/PcFKFq0YLB/yt/ZPkSyOOZWmzH1G1s5rJxy/PqG5vBNNl3niwPs1Z6sWLAu PfHTROJg5wmDqO7Bb4vU7mojr+729MIIUyMPW9yr89UeqIuQdUALI8bHXMYu7rcBhxKA Pnl7U9MNBOMFVYYXN2QleUwttr5w/MGfEPCPymKpkXd/ajJwIOhJOheFHuKhDF4/wAAA /lXxbOzTiBIgg3WgKBiJQO7e/fgaJt3Dhw0OX1g5rxbOg2j+YnCcLlmxiPF3LppxyBHS dfsoKYadLE1lnH8fB3Twq6aGIY6pk1D803vGmLRiukjaaZfW3a/BfrMOxWeLDN2tLXRR sqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5i/D5TieuUrhJvVB+CfP7tSnYyWSWzLsRDk97jx831A=; b=XU5AoGceaWA9Ue+NJwzKXLd6Pq7yrtcC+8qGGnp7ujnoZuJR4FTrcEthXfKup7lgdv YBTKzUeSS4N5jhUBDMzHS4Quv/H+r3dd50dmehw5uoSVjq+rNcuvXvw4pTSf3Yf7aGB0 PH9mI/k/OnZDZGAhrhN8/lDZhG5EW6nbYkshP2wHmstrdp5zjfUxyrrFDb/oLmUsKjVq QsZytp4EX8KCquZV+sQVJ9Qj5atcZYnTjU6G6NnSwt4IsjGdLnHMyN1smXwPZyG8cgdA n3ZL2YINHZLsp6Ysv80b/4gqIcO/sn0a2Vvie2nUVBJw2joHYK40+ewD0q3xQogbitiD +J6g== X-Gm-Message-State: AG10YORxzSjF0DyuNNlkk1DsnX9etx7gTtT/bcg1V5+VQHeZxuxt6AU5HH1h+w6cZ0LUIjkJ X-Received: by 10.66.228.231 with SMTP id sl7mr7843053pac.30.1456184109100; Mon, 22 Feb 2016 15:35:09 -0800 (PST) Received: from localhost ([2620:0:1009:3:b080:5ad3:222b:6c77]) by smtp.gmail.com with ESMTPSA id u24sm39216189pfa.94.2016.02.22.15.35.07 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 22 Feb 2016 15:35:08 -0800 (PST) From: Peter Feiner To: kvm@vger.kernel.org, drjones@redhat.com, pbonzini@redhat.com Cc: pfeiner@google.com Subject: [kvm-unit-tests PATCH] x86: vmx: actually allocate io_bitmap_b Date: Mon, 22 Feb 2016 15:35:00 -0800 Message-Id: <1456184100-30323-1-git-send-email-pfeiner@google.com> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Test would run and pass with io_bitmap_b = 0. I discovered the problem while developing a new test. I expected to get an 'Unhandled cpu exception 14' message but the test VM rebooted instead. I suspect it hit a triple fault but I didn't debug further. Signed-off-by: Peter Feiner --- x86/vmx_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c index 451fdd7..bb65c06 100644 --- a/x86/vmx_tests.c +++ b/x86/vmx_tests.c @@ -566,7 +566,7 @@ static int iobmp_init() u32 ctrl_cpu0; io_bitmap_a = alloc_page(); - io_bitmap_a = alloc_page(); + io_bitmap_b = alloc_page(); memset(io_bitmap_a, 0x0, PAGE_SIZE); memset(io_bitmap_b, 0x0, PAGE_SIZE); ctrl_cpu0 = vmcs_read(CPU_EXEC_CTRL0);