From patchwork Thu Mar 3 20:48:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Feiner X-Patchwork-Id: 8496131 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C146BC0553 for ; Thu, 3 Mar 2016 20:48:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BB8302025B for ; Thu, 3 Mar 2016 20:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA4C620295 for ; Thu, 3 Mar 2016 20:48:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756948AbcCCUsu (ORCPT ); Thu, 3 Mar 2016 15:48:50 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:36855 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757429AbcCCUsr (ORCPT ); Thu, 3 Mar 2016 15:48:47 -0500 Received: by mail-pf0-f182.google.com with SMTP id 63so21214031pfe.3 for ; Thu, 03 Mar 2016 12:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qjiFv+BBbmZQScLo/aYx7J4iQRSexoPEkRgoi2YyhSQ=; b=WkPPb52INAEjgB6GwZ/rgbQE9UDJ/Ao84PLvJXJhHlf9iqWmFU0Ysc+kwt+nqSZAGI CPyXl7HaY70/BkBkY0EsVg3DE1DNt7haZ9Vayq+OLluDpFTNlyFoKrUWj+/NTpaaPMxe dvFPt2HksZy6zZwQ8k/zs2mtJz87igeyKjFd22C/RCcpb0nGq83FXfrW6qR9qSeNT2Me 7zxacFcfRYXJ/Fj5M8gYriC0Kc9IojIu1zhXS0XrhhY6erOROsGpIyW7IhV41Ptye8WE zHH6J8m3Zr0ME/cVP0LCOiKXGz8fe7NU8WluMeE/c3Obasc6qX2rMnQPEneO5PHy2zy5 a7jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qjiFv+BBbmZQScLo/aYx7J4iQRSexoPEkRgoi2YyhSQ=; b=T0MRo0OdiAa9FisatDv9PPOoM1wJiwWblj3DrFZqDBKvQitKCcPnvP6VkT8PkRFLXy wXFt6MRLLPT5RLlRMWTwUtaeAkIVm/pf1b9Khg5KY4eLTjtv3SmrJoV4KhSPKyZq1PVN +SlMpaxjGt9gfoXnEnnAC6v1qv/TzEyvf7gN7R7e/8fMYhVXkXEl49XHFTq3DUmv0ldH ywYPpGs8bM9uAJZEhQugCvaRDZ6GzCr33oflxsNuRbGAlm7vqMb9UFzlMoVZy3t+l9uh Kl+8O69MxYlzCyC8Am6RTOc3zS9wf69qRp3PlGUBNEJwRVoSr5n64DQTwH3Xf1rUOK5f xaUA== X-Gm-Message-State: AD7BkJI0a9fSqSMgifl3AqeIpZP9y+qbbOt2KYbqv8yzlIPl7LAIAn2AjPhumhvz2v9sCJQ8 X-Received: by 10.98.16.12 with SMTP id y12mr6705710pfi.6.1457038126761; Thu, 03 Mar 2016 12:48:46 -0800 (PST) Received: from localhost ([2620:0:1009:3:48a8:c9fe:5013:71d]) by smtp.gmail.com with ESMTPSA id v11sm200150pfa.60.2016.03.03.12.48.45 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 03 Mar 2016 12:48:45 -0800 (PST) From: Peter Feiner To: kvm@vger.kernel.org, drjones@redhat.com, pbonzini@redhat.com Cc: pfeiner@google.com Subject: [kvm-unit-tests v3 4/4] scripts: pretty print stack traces Date: Thu, 3 Mar 2016 12:48:36 -0800 Message-Id: <1457038116-3448-5-git-send-email-pfeiner@google.com> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1457038116-3448-1-git-send-email-pfeiner@google.com> References: <1456867658-10937-1-git-send-email-pfeiner@google.com> <1457038116-3448-1-git-send-email-pfeiner@google.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Optionally pretty print stacks in test.log with 'run_tests.sh -p'. The script runs addresses through addr2line to get file names and line numbers. Also prints out source code lines if files are available. For example 0x004013f5: ac_test_exec at x86/access.c:818 } > ac_test_setup_pte(at, pool); r = ac_test_do_access(at); 0x004014dd: ac_test_run at x86/access.c:852 ++tests; > successes += ac_test_exec(&at, &pool); } while (ac_test_bump(&at)); 0x0040157d: main at x86/access.c:873 printf("starting test\n\n"); > r = ac_test_run(); return r ? 0 : 1; 0x0040028e: start64 at x86/cstart64.S:206 lea __argv(%rip), %rsi > call main mov %eax, %edi Signed-off-by: Peter Feiner --- run_tests.sh | 10 ++++- scripts/pretty_print_stacks.py | 89 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 97 insertions(+), 2 deletions(-) create mode 100755 scripts/pretty_print_stacks.py diff --git a/run_tests.sh b/run_tests.sh index 89e8f84..b6f2003 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -1,6 +1,7 @@ #!/bin/bash verbose="no" +pretty="no" if [ ! -f config.mak ]; then echo "run ./configure && make first. See ./configure -h" @@ -18,6 +19,7 @@ Usage: $0 [-g group] [-h] [-v] -g: Only execute tests in the given group -h: Output this help text -v: Enables verbose mode + -p: Pretty print stack traces in test.log Set the environment variable QEMU=/path/to/qemu-system-ARCH to specify the appropriate qemu binary for ARCH-run. @@ -27,8 +29,9 @@ EOF RUNTIME_arch_run="./$TEST_DIR/run" source scripts/runtime.bash +log_redir=">> test.log" -while getopts "g:hv" opt; do +while getopts "g:hvp" opt; do case $opt in g) only_group=$OPTARG @@ -40,13 +43,16 @@ while getopts "g:hv" opt; do v) verbose="yes" ;; + p) + log_redir="> >(./scripts/pretty_print_stacks.py \$kernel >> test.log)" + ;; *) exit 1 ;; esac done -RUNTIME_arch_run="./$TEST_DIR/run >> test.log" +RUNTIME_arch_run="./$TEST_DIR/run $log_redir" config=$TEST_DIR/unittests.cfg rm -f test.log printf "BUILD_HEAD=$(cat build-head)\n\n" > test.log diff --git a/scripts/pretty_print_stacks.py b/scripts/pretty_print_stacks.py new file mode 100755 index 0000000..ee5a52e --- /dev/null +++ b/scripts/pretty_print_stacks.py @@ -0,0 +1,89 @@ +#!/usr/bin/env python + +import re +import subprocess +import sys +import traceback + +# Subvert output buffering. +def puts(string): + sys.stdout.write(string) + sys.stdout.flush() + +def pretty_print_stack(binary, line): + addrs = line.split()[1:] + # Addresses are return addresses unless preceded by a '@'. We want the + # caller address so line numbers are more intuitive. Thus we subtract 1 + # from the address to get the call code. + for i in range(len(addrs)): + addr = addrs[i] + if addr.startswith('@'): + addrs[i] = addr[1:] + else: + addrs[i] = '%lx' % (int(addrs[i], 16) - 1) + + # Output like this: + # 0x004002be: start64 at path/to/kvm-unit-tests/x86/cstart64.S:208 + # (inlined by) test_ept_violation at path/to/kvm-unit-tests/x86/vmx_tests.c:1719 (discriminator 1) + cmd = ['addr2line', '-e', binary, '-i', '-f', '--pretty', '--address'] + cmd.extend(addrs) + + p = subprocess.Popen(cmd, stdout=subprocess.PIPE) + out, err = p.communicate() + if p.returncode != 0: + puts(line) + return + + for line in out.splitlines(): + m = re.match('(.*) at [^ ]*/kvm-unit-tests/([^ ]*):([0-9]+)(.*)', line) + if m is None: + puts('%s\n' % line) + return + + head, path, line, tail = m.groups() + line = int(line) + puts('%s at %s:%d%s\n' % (head, path, line, tail)) + try: + lines = open(path).readlines() + except IOError: + continue + if line > 1: + puts(' %s\n' % lines[line - 2].rstrip()) + puts(' > %s\n' % lines[line - 1].rstrip()) + if line < len(lines): + puts(' %s\n' % lines[line].rstrip()) + +def main(): + if len(sys.argv) != 2: + sys.stderr.write('usage: %s \n' % sys.argv[0]) + sys.exit(1) + + binary = sys.argv[1] + + try: + while True: + # Subvert input buffering. + line = sys.stdin.readline() + if line == '': + break + + if not line.strip().startswith('STACK:'): + puts(line) + continue + + try: + pretty_print_stack(binary, line) + except Exception: + puts('Error pretty printing stack:\n') + puts(traceback.format_exc()) + puts('Continuing without pretty printing...\n') + while True: + puts(line) + line = sys.stdin.readline() + if line == '': + break + except: + sys.exit(1) + +if __name__ == '__main__': + main()