From patchwork Fri Mar 4 17:09:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Feiner X-Patchwork-Id: 8506361 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D7EBDC0553 for ; Fri, 4 Mar 2016 17:09:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0FA232025B for ; Fri, 4 Mar 2016 17:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28BF220225 for ; Fri, 4 Mar 2016 17:09:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881AbcCDRJW (ORCPT ); Fri, 4 Mar 2016 12:09:22 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:36518 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbcCDRJU (ORCPT ); Fri, 4 Mar 2016 12:09:20 -0500 Received: by mail-pf0-f173.google.com with SMTP id 63so38256221pfe.3 for ; Fri, 04 Mar 2016 09:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Cv5uWRaPtDBOAWns4eIZSjTrXhLaTQTPUpUcAXRAGy4=; b=GK7Ek+k/EAPkw+buoPT0RWIwLRj0d/uHoCebsb+ODtI12IrWmCwJ/SOyRswhvDngzZ 8obz7ue2y/OgtVEmFn99s2wWW2fYrRM+5DMtXyglETzmk4hR7zFPGba6ka7ph5zR0+YE Dn9JVLGncMIV9qrDvDlwvIvXkl3rewbSkUbDUHBwxA8ICGSqYNT9I/83CH8pWXiXOqom /W/PohP6uUULBmX49kpsb1nB8EpK9AYHDAkmSKsleAoGfGwYmN9ic11G3Ja4CfUAupmX fj4j1WQH1IKecXoZK14PdzTnT1eu8dF+rB+pPyKhyLSFEYCzBEcc7cq9BrEXsBcvbQOn 01Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Cv5uWRaPtDBOAWns4eIZSjTrXhLaTQTPUpUcAXRAGy4=; b=jF1NTnhXZyUChXwD58Psj5ckjTG1SsEDEjylivzaDBb2Wnnp0RqsK02M/Wlj8RYARC gMZUfSWMfbq2GZQAU2s3J8gT5ufhX64RiV2WsKRaNeh//5v3QcEYa12XhPztB70LSnku Ki3e4HcTVa71RrSZjZUEnmaSZ9mvocFccYPhoAlsZ6t5S+9DIaO28x0NZvHmqCFMNPfI jvfj9iXLe6R+zBLvm8hNSwkwUtuEhWkHxu2T0yQbqkU2JuHUOO//KMyq4HW8YuhNAH4S gl4WpkEjqQF3u2yaHkmP7DUc1vzgnjuqbY5jupeLUZ399MK7uJ9BLnwFD2oNXqZsw0Uz o74A== X-Gm-Message-State: AD7BkJJgs0+lY/kAz1YPcgY/rhhKrBLGsoH/7aqDK4jkvJc+LKznCxPQgngJDR2I0GYd4S37 X-Received: by 10.98.1.203 with SMTP id 194mr13908166pfb.10.1457111360008; Fri, 04 Mar 2016 09:09:20 -0800 (PST) Received: from localhost ([2620:0:1009:3:90d6:d6fe:49e8:86b0]) by smtp.gmail.com with ESMTPSA id fa3sm6756706pab.45.2016.03.04.09.09.19 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 04 Mar 2016 09:09:19 -0800 (PST) From: Peter Feiner To: kvm@vger.kernel.org, drjones@redhat.com, pbonzini@redhat.com Cc: pfeiner@google.com Subject: [PATCH kvm-unit-tests v2] powerpc: fix boot_rom.bin build Date: Fri, 4 Mar 2016 09:09:17 -0800 Message-Id: <1457111357-5809-1-git-send-email-pfeiner@google.com> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1457038529-4577-1-git-send-email-pfeiner@google.com> References: <1457038529-4577-1-git-send-email-pfeiner@google.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP My powerpc objcopy (version 2.23.52.20130305) did a seek() that bash process substitution couldn't handle! I've changed the Makefile to do things the old fashioned way. Signed-off-by: Peter Feiner Reviewed-by: Andrew Jones --- v2: * rm the temporary file * renamed temporary file to .tmp instead of .suffix --- powerpc/Makefile.common | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common index 424983e..2074289 100644 --- a/powerpc/Makefile.common +++ b/powerpc/Makefile.common @@ -48,7 +48,9 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive) $(TEST_DIR)/boot_rom.bin: $(TEST_DIR)/boot_rom.elf dd if=/dev/zero of=$@ bs=256 count=1 - $(OBJCOPY) -O binary $^ >(cat - >>$@) + $(OBJCOPY) -O binary $^ $@.tmp + cat $@.tmp >> $@ + $(RM) $@.tmp $(TEST_DIR)/boot_rom.elf: CFLAGS = -mbig-endian $(TEST_DIR)/boot_rom.elf: $(TEST_DIR)/boot_rom.o