diff mbox

vmx: refine validity check for guest line address

Message ID 1471506559-20712-1-git-send-email-liang.z.li@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Liang Li Aug. 18, 2016, 7:49 a.m. UTC 
The validity check for the guest line address is inefficient,
check the invalid value instead is more efficient.

Signed-off-by: Liang Li <liang.z.li@intel.com>
---
 arch/x86/kvm/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paolo Bonzini Aug. 18, 2016, 10:08 a.m. UTC | #1 
On 18/08/2016 09:49, Liang Li wrote:
> The validity check for the guest line address is inefficient,
> check the invalid value instead is more efficient.
> 
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> ---
>  arch/x86/kvm/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index a45d858..c32d5e8 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6103,7 +6103,7 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu)
>  	exit_qualification = vmcs_readl(EXIT_QUALIFICATION);
>  
>  	gla_validity = (exit_qualification >> 7) & 0x3;
> -	if (gla_validity != 0x3 && gla_validity != 0x1 && gla_validity != 0) {
> +	if (gla_validity == 0x2) {
>  		printk(KERN_ERR "EPT: Handling EPT violation failed!\n");
>  		printk(KERN_ERR "EPT: GPA: 0x%lx, GVA: 0x%lx\n",
>  			(long unsigned int)vmcs_read64(GUEST_PHYSICAL_ADDRESS),
> 

Queued for 4.9, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index a45d858..c32d5e8 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -6103,7 +6103,7 @@  static int handle_ept_violation(struct kvm_vcpu *vcpu)
 	exit_qualification = vmcs_readl(EXIT_QUALIFICATION);
 
 	gla_validity = (exit_qualification >> 7) & 0x3;
-	if (gla_validity != 0x3 && gla_validity != 0x1 && gla_validity != 0) {
+	if (gla_validity == 0x2) {
 		printk(KERN_ERR "EPT: Handling EPT violation failed!\n");
 		printk(KERN_ERR "EPT: GPA: 0x%lx, GVA: 0x%lx\n",
 			(long unsigned int)vmcs_read64(GUEST_PHYSICAL_ADDRESS),