From patchwork Wed Feb 15 19:51:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baicar X-Patchwork-Id: 9574927 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DFA9A60209 for ; Wed, 15 Feb 2017 19:53:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD4D728515 for ; Wed, 15 Feb 2017 19:53:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE6E928527; Wed, 15 Feb 2017 19:53:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6003628515 for ; Wed, 15 Feb 2017 19:53:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751588AbdBOTx1 (ORCPT ); Wed, 15 Feb 2017 14:53:27 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34998 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbdBOTwc (ORCPT ); Wed, 15 Feb 2017 14:52:32 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1BBF760DA9; Wed, 15 Feb 2017 19:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1487188346; bh=gDL9FLOZo1AaYu4ZMXJPMTxg+9oDauRVMU72oA6xeT0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g8U9ivVG+wdK+kCQH1eO11ckrmYpld1boCTXTSAIavl/zoCPMMlTeEKiCq6CxI4FT xhYra0Gdk2Cged3U/NIisAfTDMGT9uks5FvGEAQiFuUnY8pfltgGUlyouQUaAl3nxI RFqkYKBycVwyNuO4BiMvtVpmkCdwXJETiMX+tN7Q= Received: from tbaicar-lnx.qualcomm.com (unknown [129.46.14.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tbaicar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DA23C60E7A; Wed, 15 Feb 2017 19:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1487188318; bh=gDL9FLOZo1AaYu4ZMXJPMTxg+9oDauRVMU72oA6xeT0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bNi5ABFDxERyZJDJqJrSJFoUs2Nfm9H4Q5ErrZMSP3F5eKcft6soDI7QJM9zVa2U4 oViThtIfTGOS1gg2VfEBKbD8FYyStp7/R9icZYT8kpSNJWfCFwP2asuDPmtZs0KWY1 tXce3sbu0j6vEoYoW7lPxn6l/+/UHBWRWLTA+I4c= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DA23C60E7A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org From: Tyler Baicar To: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, matt@codeblueprint.co.uk, robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org, zjzhang@codeaurora.org, mark.rutland@arm.com, james.morse@arm.com, akpm@linux-foundation.org, eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com, labbott@redhat.com, shijie.huang@arm.com, rruigrok@codeaurora.org, paul.gortmaker@windriver.com, tn@semihalf.com, fu.wei@linaro.org, rostedt@goodmis.org, bristot@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, devel@acpica.org, Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com, harba@codeaurora.org, hanjun.guo@linaro.org, john.garry@huawei.com, shiju.jose@huawei.com Cc: Tyler Baicar Subject: [PATCH V10 07/10] efi: print unrecognized CPER section Date: Wed, 15 Feb 2017 12:51:19 -0700 Message-Id: <1487188282-2568-8-git-send-email-tbaicar@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1487188282-2568-1-git-send-email-tbaicar@codeaurora.org> References: <1487188282-2568-1-git-send-email-tbaicar@codeaurora.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with one of the section types that the kernel knows how to parse, the section is skipped. Therefore, user is not able to see such CPER data, for instance, error record of non-standard section. For above mentioned case, this change prints out the raw data in hex in dmesg buffer. Data length is taken from Error Data length field of Generic Error Data Entry. Following is a sample output from dmesg: [ 115.771702] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 2 [ 115.779042] {1}[Hardware Error]: It has been corrected by h/w and requires no further action [ 115.787456] {1}[Hardware Error]: event severity: corrected [ 115.792927] {1}[Hardware Error]: Error 0, type: corrected [ 115.798415] {1}[Hardware Error]: fru_id: 00000000-0000-0000-0000-000000000000 [ 115.805596] {1}[Hardware Error]: fru_text: [ 115.816105] {1}[Hardware Error]: section type: d2e2621c-f936-468d-0d84-15a4ed015c8b [ 115.823880] {1}[Hardware Error]: section length: 88 [ 115.828779] {1}[Hardware Error]: 00000000: 01000001 00000002 5f434345 525f4543 [ 115.836153] {1}[Hardware Error]: 00000010: 0000574d 00000000 00000000 00000000 [ 115.843531] {1}[Hardware Error]: 00000020: 00000000 00000000 00000000 00000000 [ 115.850908] {1}[Hardware Error]: 00000030: 00000000 00000000 00000000 00000000 [ 115.858288] {1}[Hardware Error]: 00000040: fe800000 00000000 00000004 5f434345 [ 115.865665] {1}[Hardware Error]: 00000050: 525f4543 0000574d Signed-off-by: Tyler Baicar Signed-off-by: Jonathan (Zhixiong) Zhang Reviewed-by: James Morse --- drivers/firmware/efi/cper.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index c2b0a12..48cb8ee 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -591,8 +591,16 @@ static void cper_estatus_print_section( cper_print_proc_arm(newpfx, arm_err); else goto err_section_too_small; - } else - printk("%s""section type: unknown, %pUl\n", newpfx, sec_type); + } else { + const void *unknown_err; + + unknown_err = acpi_hest_generic_data_payload(gdata); + printk("%ssection type: %pUl\n", newpfx, sec_type); + printk("%ssection length: %d\n", newpfx, + gdata->error_data_length); + print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16, 4, + unknown_err, gdata->error_data_length, 0); + } return;