From patchwork Tue Feb 21 21:21:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baicar X-Patchwork-Id: 9585731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1247E600C1 for ; Tue, 21 Feb 2017 21:24:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC46D28620 for ; Tue, 21 Feb 2017 21:24:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E037528643; Tue, 21 Feb 2017 21:24:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41BDE28620 for ; Tue, 21 Feb 2017 21:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbdBUVYu (ORCPT ); Tue, 21 Feb 2017 16:24:50 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47072 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbdBUVXy (ORCPT ); Tue, 21 Feb 2017 16:23:54 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9314260FEA; Tue, 21 Feb 2017 21:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1487712232; bh=PbSg+KOIhuMtUcSRg5NuDgiVqdLGMMiKI3TB44NUkEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BZM7MisPH4we0L2BRikxaKjNBL9i4o/qXfwzuwGTrzxWtGm8pSSSkAgsezsstsSUO SpeWkVliMFhf+HPCZQYdwupOZr3I14p/Lz9+tmPmsGJ5l6Lt/McLqKABESK0GTMygS 2uFs5xi5wWIoMPMO5Rk5BHTNZhYZzK7Zq26o03yQ= Received: from tbaicar-lnx.qualcomm.com (unknown [129.46.14.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tbaicar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 096DF60F6F; Tue, 21 Feb 2017 21:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1487712167; bh=PbSg+KOIhuMtUcSRg5NuDgiVqdLGMMiKI3TB44NUkEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cLcjrIZoLkueSMUlv1IC6bypKJw8v8rpXoMLGwisoAOhx8VotKxFi4ctpI3QpsmmE jocFnLR/ugSqztDHWJ8ekZuwuH5M8cq0e53MJyMfeDkHk8c68OhbgTAIBm0leCvT3V kUa/gQNGA0dUFdezbk2YOjyXHGdCgBsHHpt3FOSI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 096DF60F6F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org From: Tyler Baicar To: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, matt@codeblueprint.co.uk, robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org, zjzhang@codeaurora.org, mark.rutland@arm.com, james.morse@arm.com, akpm@linux-foundation.org, eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com, labbott@redhat.com, shijie.huang@arm.com, rruigrok@codeaurora.org, paul.gortmaker@windriver.com, tn@semihalf.com, fu.wei@linaro.org, rostedt@goodmis.org, bristot@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, devel@acpica.org, Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com, harba@codeaurora.org, hanjun.guo@linaro.org, john.garry@huawei.com, shiju.jose@huawei.com, joe@perches.com Cc: Tyler Baicar Subject: [PATCH V11 07/10] efi: print unrecognized CPER section Date: Tue, 21 Feb 2017 14:21:58 -0700 Message-Id: <1487712121-16688-8-git-send-email-tbaicar@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1487712121-16688-1-git-send-email-tbaicar@codeaurora.org> References: <1487712121-16688-1-git-send-email-tbaicar@codeaurora.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with one of the section types that the kernel knows how to parse, the section is skipped. Therefore, user is not able to see such CPER data, for instance, error record of non-standard section. For above mentioned case, this change prints out the raw data in hex in dmesg buffer. Data length is taken from Error Data length field of Generic Error Data Entry. Following is a sample output from dmesg: [ 115.771702] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 2 [ 115.779042] {1}[Hardware Error]: It has been corrected by h/w and requires no further action [ 115.787456] {1}[Hardware Error]: event severity: corrected [ 115.792927] {1}[Hardware Error]: Error 0, type: corrected [ 115.798415] {1}[Hardware Error]: fru_id: 00000000-0000-0000-0000-000000000000 [ 115.805596] {1}[Hardware Error]: fru_text: [ 115.816105] {1}[Hardware Error]: section type: d2e2621c-f936-468d-0d84-15a4ed015c8b [ 115.823880] {1}[Hardware Error]: section length: 88 [ 115.828779] {1}[Hardware Error]: 00000000: 01000001 00000002 5f434345 525f4543 [ 115.836153] {1}[Hardware Error]: 00000010: 0000574d 00000000 00000000 00000000 [ 115.843531] {1}[Hardware Error]: 00000020: 00000000 00000000 00000000 00000000 [ 115.850908] {1}[Hardware Error]: 00000030: 00000000 00000000 00000000 00000000 [ 115.858288] {1}[Hardware Error]: 00000040: fe800000 00000000 00000004 5f434345 [ 115.865665] {1}[Hardware Error]: 00000050: 525f4543 0000574d The raw data from the error can then be decoded using vendor specific tools. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang Reviewed-by: James Morse --- drivers/firmware/efi/cper.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index 0238877..d1b6edc 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -591,8 +591,16 @@ static void cper_estatus_print_section( cper_print_proc_arm(newpfx, arm_err); else goto err_section_too_small; - } else + } else { + const void *unknown_err; + + unknown_err = acpi_hest_generic_data_payload(gdata); printk("%s""section type: unknown, %pUl\n", newpfx, sec_type); + printk("%s""section length: %d\n", newpfx, + gdata->error_data_length); + print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16, 4, + unknown_err, gdata->error_data_length, true); + } return;