From patchwork Mon May 15 21:27:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baicar X-Patchwork-Id: 9728041 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 49CFC6028A for ; Mon, 15 May 2017 21:30:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 59C4C289D7 for ; Mon, 15 May 2017 21:30:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DD27289DE; Mon, 15 May 2017 21:30:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF26D289D7 for ; Mon, 15 May 2017 21:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933967AbdEOV2y (ORCPT ); Mon, 15 May 2017 17:28:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49522 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933825AbdEOV2u (ORCPT ); Mon, 15 May 2017 17:28:50 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 888176084E; Mon, 15 May 2017 21:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1494883729; bh=FosWoTSHkyxh7+K88fQ+LImgftTSF6vBFJlRWdjg9uM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=USHa1jpmEPynEgs+y1JaENiXbw76OeNTWXC52AnQspAqUDFtXkbj9QgKYfqhySf5f 4eRoN801r/0tDiVuBdJvlrY+3dL4Z8MqAs5SIt4eMOKYDN14B7AhGVTP6TPSh6/2/2 erBz+ni7fsCIUxz85KL2znV9dDia22EdNQpTMu7I= Received: from tbaicar-lnx.qualcomm.com (unknown [129.46.14.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tbaicar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 668B260DB3; Mon, 15 May 2017 21:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1494883722; bh=FosWoTSHkyxh7+K88fQ+LImgftTSF6vBFJlRWdjg9uM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QdF/RfmH+bWcXCkRGBgBFONNoOS/RdrCYBCc8aqhmDJgm1TFOTsa3d5p3cZ6z1V1E XG5+X4mgSAMqUYEBTkKZnhc4oAmDTm4/2SqaW3XfPSMWVabEXft8qrpVb8a7ImyzMr DJzcAJmpn/6ZDzXgyKh/6H7lCoT4fUkpe4EH6cts= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 668B260DB3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org From: Tyler Baicar To: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, matt@codeblueprint.co.uk, robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org, zjzhang@codeaurora.org, mark.rutland@arm.com, james.morse@arm.com, akpm@linux-foundation.org, eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com, labbott@redhat.com, shijie.huang@arm.com, rruigrok@codeaurora.org, paul.gortmaker@windriver.com, tn@semihalf.com, fu.wei@linaro.org, rostedt@goodmis.org, bristot@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com, harba@codeaurora.org, hanjun.guo@linaro.org, john.garry@huawei.com, shiju.jose@huawei.com, joe@perches.com, bp@alien8.de, rafael@kernel.org, tony.luck@intel.com, gengdongjiu@huawei.com, xiexiuqi@huawei.com Cc: Tyler Baicar Subject: [PATCH V16 08/11] efi: print unrecognized CPER section Date: Mon, 15 May 2017 15:27:57 -0600 Message-Id: <1494883680-25551-9-git-send-email-tbaicar@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1494883680-25551-1-git-send-email-tbaicar@codeaurora.org> References: <1494883680-25551-1-git-send-email-tbaicar@codeaurora.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with one of the section types that the kernel knows how to parse, the section is skipped. Therefore, user is not able to see such CPER data, for instance, error record of non-standard section. This change prints out the raw data in hex in the dmesg buffer so that non-standard sections are reported to the user. Non-standard section type errors should be reported to the user because these can include errors which are vendor specific. The data length is taken from Error Data length field of Generic Error Data Entry. The following is a sample output from dmesg: [ 140.739180] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 2 [ 140.739182] {1}[Hardware Error]: It has been corrected by h/w and requires no further action [ 140.739191] {1}[Hardware Error]: event severity: corrected [ 140.739196] {1}[Hardware Error]: time: precise 2017-03-15 20:37:35 [ 140.739197] {1}[Hardware Error]: Error 0, type: corrected [ 140.739203] {1}[Hardware Error]: section type: unknown, d2e2621c-f936-468d-0d84-15a4ed015c8b [ 140.739205] {1}[Hardware Error]: section length: 0x238 [ 140.739210] {1}[Hardware Error]: 00000000: 4d415201 4d492031 453a4d45 435f4343 .RAM1 IMEM:ECC_C [ 140.739214] {1}[Hardware Error]: 00000010: 53515f45 44525f42 00000000 00000000 E_QSB_RD........ [ 140.739217] {1}[Hardware Error]: 00000020: 00000000 00000000 00000000 00000000 ................ [ 140.739220] {1}[Hardware Error]: 00000030: 00000000 00000000 01010000 01010000 ................ [ 140.739223] {1}[Hardware Error]: 00000040: 00000000 00000000 00000005 00000000 ................ [ 140.739226] {1}[Hardware Error]: 00000050: 01010000 00000000 00000001 00dddd00 ................ ... The raw data from the error can then be decoded using vendor specific tools. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang Reviewed-by: James Morse --- drivers/firmware/efi/cper.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index eac0854..d5a5855 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -585,8 +585,15 @@ static void cper_print_tstamp(const char *pfx, else goto err_section_too_small; #endif - } else - printk("%s""section type: unknown, %pUl\n", newpfx, sec_type); + } else { + const void *err = acpi_hest_get_payload(gdata); + + printk("%ssection type: unknown, %pUl\n", newpfx, sec_type); + printk("%ssection length: %#x\n", newpfx, + gdata->error_data_length); + print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16, 4, err, + gdata->error_data_length, true); + } return;