| Message ID | 1511427665-21660-3-git-send-email-paulus@ozlabs.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Based on your comments, this is fine. On Thu, Nov 23, 2017 at 08:01:02PM +1100, Paul Mackerras wrote: >This fixes a typo where the intent was to assign to 'j' in order to >skip some number of bits in the dirty bitmap for a guest. The effect >of the typo is benign since it means we just iterate through all the >bits rather than skipping bits which we know will be zero. This issue >was found by Coverity. > Reviewed-by: Darren Kenny <darren.kenny@oracle.com> >Signed-off-by: Paul Mackerras <paulus@ozlabs.org> >--- > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/arch/powerpc/kvm/book3s_64_mmu_radix.c b/arch/powerpc/kvm/book3s_64_mmu_radix.c >index 58618f6..0c85481 100644 >--- a/arch/powerpc/kvm/book3s_64_mmu_radix.c >+++ b/arch/powerpc/kvm/book3s_64_mmu_radix.c >@@ -573,7 +573,7 @@ long kvmppc_hv_get_dirty_log_radix(struct kvm *kvm, > j = i + 1; > if (npages) { > set_dirty_bits(map, i, npages); >- i = j + npages; >+ j = i + npages; > } > } > return 0; >-- >2.7.4 >
diff --git a/arch/powerpc/kvm/book3s_64_mmu_radix.c b/arch/powerpc/kvm/book3s_64_mmu_radix.c index 58618f6..0c85481 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_radix.c +++ b/arch/powerpc/kvm/book3s_64_mmu_radix.c @@ -573,7 +573,7 @@ long kvmppc_hv_get_dirty_log_radix(struct kvm *kvm, j = i + 1; if (npages) { set_dirty_bits(map, i, npages); - i = j + npages; + j = i + npages; } } return 0;
This fixes a typo where the intent was to assign to 'j' in order to skip some number of bits in the dirty bitmap for a guest. The effect of the typo is benign since it means we just iterate through all the bits rather than skipping bits which we know will be zero. This issue was found by Coverity. Signed-off-by: Paul Mackerras <paulus@ozlabs.org> --- arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)