From patchwork Wed Jan 29 12:16:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi Liu X-Patchwork-Id: 11356041 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A31F112B for ; Wed, 29 Jan 2020 12:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79FF720720 for ; Wed, 29 Jan 2020 12:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbgA2MLs (ORCPT ); Wed, 29 Jan 2020 07:11:48 -0500 Received: from mga04.intel.com ([192.55.52.120]:15927 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbgA2MLq (ORCPT ); Wed, 29 Jan 2020 07:11:46 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 04:11:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,377,1574150400"; d="scan'208";a="314070811" Received: from jacob-builder.jf.intel.com ([10.7.199.155]) by fmsmga001.fm.intel.com with ESMTP; 29 Jan 2020 04:11:44 -0800 From: "Liu, Yi L" To: qemu-devel@nongnu.org, david@gibson.dropbear.id.au, pbonzini@redhat.com, alex.williamson@redhat.com, peterx@redhat.com Cc: mst@redhat.com, eric.auger@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, jun.j.tian@intel.com, yi.y.sun@intel.com, kvm@vger.kernel.org, hao.wu@intel.com, Jacob Pan , Yi Sun Subject: [RFC v3 03/25] hw/iommu: introduce IOMMUContext Date: Wed, 29 Jan 2020 04:16:34 -0800 Message-Id: <1580300216-86172-4-git-send-email-yi.l.liu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1580300216-86172-1-git-send-email-yi.l.liu@intel.com> References: <1580300216-86172-1-git-send-email-yi.l.liu@intel.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Peter Xu Currently, many platform vendors provide the capability of dual stage DMA address translation in hardware. For example, nested translation on Intel VT-d scalable mode, nested stage translation on ARM SMMUv3, and etc. Also there are efforts to make QEMU vIOMMU be backed by dual stage DMA address translation capability provided by hardware to have better address translation support for passthru devices. As so, making vIOMMU be backed by dual stage translation capability requires QEMU vIOMMU to have a way to get aware of such hardware capability and also require a way to receive DMA address translation faults (e.g. I/O page request) from host as guest owns stage-1 translation structures in dual stage DAM address translation. This patch adds IOMMUContext as an abstract of vIOMMU related operations. Like provide a way for passthru modules (e.g. VFIO) to register DualStageIOMMUObject instances. And in future, it is expected to offer support for receiving host DMA translation faults happened on stage-1 translation. For more backgrounds, may refer to the discussion below, while there is also difference between the current implementation and original proposal. This patch introduces the IOMMUContext as an abstract layer for passthru module (e.g. VFIO) calls into vIOMMU. The first introduced interface is to make QEMU vIOMMU be aware of dual stage translation capability. https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg05022.html Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun Cc: David Gibson Signed-off-by: Peter Xu Signed-off-by: Liu Yi L --- hw/iommu/Makefile.objs | 1 + hw/iommu/iommu_context.c | 54 +++++++++++++++++++++++++++++++++++ include/hw/iommu/iommu_context.h | 61 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 116 insertions(+) create mode 100644 hw/iommu/iommu_context.c create mode 100644 include/hw/iommu/iommu_context.h diff --git a/hw/iommu/Makefile.objs b/hw/iommu/Makefile.objs index d4f3b39..1e45072 100644 --- a/hw/iommu/Makefile.objs +++ b/hw/iommu/Makefile.objs @@ -1 +1,2 @@ obj-y += dual_stage_iommu.o +obj-y += iommu_context.o diff --git a/hw/iommu/iommu_context.c b/hw/iommu/iommu_context.c new file mode 100644 index 0000000..6340ca3 --- /dev/null +++ b/hw/iommu/iommu_context.c @@ -0,0 +1,54 @@ +/* + * QEMU abstract of vIOMMU context + * + * Copyright (C) 2020 Red Hat Inc. + * + * Authors: Peter Xu , + * Liu Yi L + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + + * You should have received a copy of the GNU General Public License along + * with this program; if not, see . + */ + +#include "qemu/osdep.h" +#include "hw/iommu/iommu_context.h" + +int iommu_context_register_ds_iommu(IOMMUContext *iommu_ctx, + DualStageIOMMUObject *dsi_obj) +{ + if (!iommu_ctx || !dsi_obj) { + return -ENOENT; + } + + if (iommu_ctx->ops && iommu_ctx->ops->register_ds_iommu) { + return iommu_ctx->ops->register_ds_iommu(iommu_ctx, dsi_obj); + } + return -ENOENT; +} + +void iommu_context_unregister_ds_iommu(IOMMUContext *iommu_ctx, + DualStageIOMMUObject *dsi_obj) +{ + if (!iommu_ctx || !dsi_obj) { + return; + } + + if (iommu_ctx->ops && iommu_ctx->ops->unregister_ds_iommu) { + iommu_ctx->ops->unregister_ds_iommu(iommu_ctx, dsi_obj); + } +} + +void iommu_context_init(IOMMUContext *iommu_ctx, IOMMUContextOps *ops) +{ + iommu_ctx->ops = ops; +} diff --git a/include/hw/iommu/iommu_context.h b/include/hw/iommu/iommu_context.h new file mode 100644 index 0000000..6f2ccb5 --- /dev/null +++ b/include/hw/iommu/iommu_context.h @@ -0,0 +1,61 @@ +/* + * QEMU abstraction of IOMMU Context + * + * Copyright (C) 2020 Red Hat Inc. + * + * Authors: Peter Xu , + * Liu, Yi L + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + + * You should have received a copy of the GNU General Public License along + * with this program; if not, see . + */ + +#ifndef HW_IOMMU_CONTEXT_H +#define HW_IOMMU_CONTEXT_H + +#include "qemu/queue.h" +#ifndef CONFIG_USER_ONLY +#include "exec/hwaddr.h" +#endif +#include "hw/iommu/dual_stage_iommu.h" + +typedef struct IOMMUContext IOMMUContext; +typedef struct IOMMUContextOps IOMMUContextOps; + +struct IOMMUContextOps { + /* + * Register DualStageIOMMUObject to vIOMMU thus vIOMMU + * is aware of dual stage translation capability, and + * also be able to setup dual stage translation via + * interfaces exposed by DualStageIOMMUObject. + */ + int (*register_ds_iommu)(IOMMUContext *iommu_ctx, + DualStageIOMMUObject *dsi_obj); + void (*unregister_ds_iommu)(IOMMUContext *iommu_ctx, + DualStageIOMMUObject *dsi_obj); +}; + +/* + * This is an abstraction of IOMMU context. + */ +struct IOMMUContext { + IOMMUContextOps *ops; +}; + +int iommu_context_register_ds_iommu(IOMMUContext *iommu_ctx, + DualStageIOMMUObject *dsi_obj); +void iommu_context_unregister_ds_iommu(IOMMUContext *iommu_ctx, + DualStageIOMMUObject *dsi_obj); +void iommu_context_init(IOMMUContext *iommu_ctx, IOMMUContextOps *ops); + +#endif