| Message ID | 1616143992-30228-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: x86: Remove unused variable rc | expand |
On 19/03/21 09:53, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./arch/x86/kvm/emulate.c:4985:5-7: Unneeded variable: "rc". Return > "X86EMUL_CONTINUE" on line 5019. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > arch/x86/kvm/emulate.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index f7970ba..8ae1e16 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -4982,8 +4982,6 @@ static unsigned imm_size(struct x86_emulate_ctxt *ctxt) > static int decode_imm(struct x86_emulate_ctxt *ctxt, struct operand *op, > unsigned size, bool sign_extension) > { > - int rc = X86EMUL_CONTINUE; > - > op->type = OP_IMM; > op->bytes = size; > op->addr.mem.ea = ctxt->_eip; > @@ -5016,7 +5014,7 @@ static int decode_imm(struct x86_emulate_ctxt *ctxt, struct operand *op, > } > } > done: > - return rc; > + return X86EMUL_CONTINUE; > } > > static int decode_operand(struct x86_emulate_ctxt *ctxt, struct operand *op, > Queued, thanks. Paolo
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index f7970ba..8ae1e16 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -4982,8 +4982,6 @@ static unsigned imm_size(struct x86_emulate_ctxt *ctxt) static int decode_imm(struct x86_emulate_ctxt *ctxt, struct operand *op, unsigned size, bool sign_extension) { - int rc = X86EMUL_CONTINUE; - op->type = OP_IMM; op->bytes = size; op->addr.mem.ea = ctxt->_eip; @@ -5016,7 +5014,7 @@ static int decode_imm(struct x86_emulate_ctxt *ctxt, struct operand *op, } } done: - return rc; + return X86EMUL_CONTINUE; } static int decode_operand(struct x86_emulate_ctxt *ctxt, struct operand *op,
Fix the following coccicheck warnings: ./arch/x86/kvm/emulate.c:4985:5-7: Unneeded variable: "rc". Return "X86EMUL_CONTINUE" on line 5019. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- arch/x86/kvm/emulate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)