From patchwork Wed Mar 11 10:07:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gleb Natapov X-Patchwork-Id: 11102 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2BA7jxj014884 for ; Wed, 11 Mar 2009 10:11:31 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753822AbZCKKLc (ORCPT ); Wed, 11 Mar 2009 06:11:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753900AbZCKKLc (ORCPT ); Wed, 11 Mar 2009 06:11:32 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42353 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771AbZCKKLb (ORCPT ); Wed, 11 Mar 2009 06:11:31 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2BABTxZ019463 for ; Wed, 11 Mar 2009 06:11:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2BABTjQ000847; Wed, 11 Mar 2009 06:11:30 -0400 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2BABScl026063; Wed, 11 Mar 2009 06:11:29 -0400 Received: by dhcp-1-237.tlv.redhat.com (Postfix, from userid 587) id 1757818D41C; Wed, 11 Mar 2009 12:07:55 +0200 (IST) Date: Wed, 11 Mar 2009 12:07:55 +0200 From: Gleb Natapov To: avi@redhat.com, marcelo@redhat.com Cc: kvm@vger.kernel.org Subject: [PATCH] do not free active mmu pages in free_mmu_pages() Message-ID: <20090311100755.GA19724@redhat.com> MIME-Version: 1.0 Content-Disposition: inline X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org free_mmu_pages() should only undo what alloc_mmu_pages() does. Signed-off-by: Gleb Natapov --- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 2a36f7f..b625ed4 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -2638,14 +2638,6 @@ EXPORT_SYMBOL_GPL(kvm_disable_tdp); static void free_mmu_pages(struct kvm_vcpu *vcpu) { - struct kvm_mmu_page *sp; - - while (!list_empty(&vcpu->kvm->arch.active_mmu_pages)) { - sp = container_of(vcpu->kvm->arch.active_mmu_pages.next, - struct kvm_mmu_page, link); - kvm_mmu_zap_page(vcpu->kvm, sp); - cond_resched(); - } free_page((unsigned long)vcpu->arch.mmu.pae_root); }