diff mbox

kvm-autotest: log test failed execption string

Message ID 20090325164322.GM27104@us.ibm.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Ryan Harper March 25, 2009, 4:43 p.m. UTC
When a test case fails and throws an execption, we don't log the
exception details, only that it occured.

reboot: DEBUG: remote_login: Got password prompt; sending '123456'
reboot: DEBUG: remote_login: Got shell prompt -- logged in
reboot: Logged in
reboot: DEBUG: run_once: Test failed; postprocessing on error...
reboot: DEBUG: postprocess_vm: Postprocessing VM 'vm1'...

The attached patch includes the exception text from the failure which makes it
easier to debug.

reboot: DEBUG: remote_login: Got password prompt; sending '123456'
reboot: DEBUG: remote_login: Got shell prompt -- logged in
reboot: Logged in
reboot: DEBUG: run_once: Test failed (invalid syntax (kvm_tests.py, line 34)); postprocessing on error...
reboot: DEBUG: postprocess_vm: Postprocessing VM 'vm1'...

Comments

Uri Lublin March 29, 2009, 5:15 p.m. UTC | #1
Ryan Harper wrote:
> When a test case fails and throws an execption, we don't log the
> exception details, only that it occured.
> 
> reboot: DEBUG: remote_login: Got password prompt; sending '123456'
> reboot: DEBUG: remote_login: Got shell prompt -- logged in
> reboot: Logged in
> reboot: DEBUG: run_once: Test failed; postprocessing on error...
> reboot: DEBUG: postprocess_vm: Postprocessing VM 'vm1'...
> 
> The attached patch includes the exception text from the failure which makes it
> easier to debug.
> 
> reboot: DEBUG: remote_login: Got password prompt; sending '123456'
> reboot: DEBUG: remote_login: Got shell prompt -- logged in
> reboot: Logged in
> reboot: DEBUG: run_once: Test failed (invalid syntax (kvm_tests.py, line 34)); postprocessing on error...
> reboot: DEBUG: postprocess_vm: Postprocessing VM 'vm1'...
> 
> 
Applied, Thanks.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diffstat output:
 kvm_runtest_2.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
diff --git a/client/tests/kvm_runtest_2/kvm_runtest_2.py b/client/tests/kvm_runtest_2/kvm_runtest_2.py
index 9add48a..cf6b699 100644
--- a/client/tests/kvm_runtest_2/kvm_runtest_2.py
+++ b/client/tests/kvm_runtest_2/kvm_runtest_2.py
@@ -91,8 +91,8 @@  class kvm_runtest_2(test.test):
                 routine_obj.routine(self, params, env)
                 env.sync()
 
-            except:
-                kvm_log.debug("Test failed; postprocessing on error...")
+            except Exception, e:
+                kvm_log.debug("Test failed (%s); postprocessing on error..." %(str(e)))
                 kvm_preprocessing.postprocess_on_error(self, params, env)
                 env.sync()
                 raise