From patchwork Thu May 14 15:49:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 23780 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4EFoox9008381 for ; Thu, 14 May 2009 15:50:50 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbZENPuP (ORCPT ); Thu, 14 May 2009 11:50:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752138AbZENPuO (ORCPT ); Thu, 14 May 2009 11:50:14 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:57180 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753348AbZENPuN convert rfc822-to-8bit (ORCPT ); Thu, 14 May 2009 11:50:13 -0400 Received: from dyn-9-152-222-92.boeblingen.de.ibm.com (blueice3n1.de.ibm.com [195.212.29.179]) by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis) id 0ML21M-1M4dC21izp-0001rs; Thu, 14 May 2009 17:49:58 +0200 From: Arnd Bergmann To: Avi Kivity Subject: Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR) Date: Thu, 14 May 2009 17:49:53 +0200 User-Agent: KMail/1.9.9 Cc: Mark McLoughlin , kvm@vger.kernel.org References: <1242203541-12959-1-git-send-email-markmc@redhat.com> <200905132157.02633.arnd@arndb.de> <4A0BD02B.1020009@redhat.com> In-Reply-To: <4A0BD02B.1020009@redhat.com> X-Face: I@=L^?./?$U, EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s, [~w]-J!)|%=]>=?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=, J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200905141749.54453.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/x7pOQWScruEbLUhpbBZn8NuCMafvrMWtgNF6 KFOOj9HzhfhWWFzlA4mIzdJPRt2hLXqlApd2W6vfrOCgxSUhPW rIccODWmPmDJDWP424uOw== Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thursday 14 May 2009, Avi Kivity wrote: > > There aren't the real kernel headers, just cheap copies carried in > qemu-kvm.git which have been appropriately postprocessed.  We do this > since the kvm external module can run on a much older kernel, so there > is no natural place to find it headers. > Sorry for the confusion on my part. I was aware of the sanitized kernel headers, but was mislead by the line kerneldir=/lib/modules/$(uname -r)/build in kvm/user/configure. What I didn't realize is that this always gets overridden by kvm/configure. Maybe we can change the default in kvm/user/configure to something more sensible: --- [PATCH] kvm: user: fix default kerneldir calling ./configure in kvm/user sets the kerneldir to the currently running kernel, which is incorrect for user code. This changes the default to the sanitized header files from the kvm/kernel directory. Signed-off-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kvm/user/configure b/kvm/user/configure index efb8705..858a519 100755 --- a/kvm/user/configure +++ b/kvm/user/configure @@ -1,7 +1,7 @@ #!/bin/bash prefix=/usr/local -kerneldir=/lib/modules/$(uname -r)/build +kerneldir="$(dirname $0)/../kernel" cc=gcc ld=ld objcopy=objcopy