From patchwork Fri Jun 19 18:51:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Haskins X-Patchwork-Id: 31394 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5JIpi1o006970 for ; Fri, 19 Jun 2009 18:51:45 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754742AbZFSSvi (ORCPT ); Fri, 19 Jun 2009 14:51:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754176AbZFSSvg (ORCPT ); Fri, 19 Jun 2009 14:51:36 -0400 Received: from victor.provo.novell.com ([137.65.250.26]:38425 "EHLO victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbZFSSvd (ORCPT ); Fri, 19 Jun 2009 14:51:33 -0400 Received: from dev.haskins.net (prv-ext-foundry1.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP (TLS encrypted); Fri, 19 Jun 2009 12:51:29 -0600 Received: from dev.haskins.net (localhost [127.0.0.1]) by dev.haskins.net (Postfix) with ESMTP id DDDAD4641EB; Fri, 19 Jun 2009 14:51:27 -0400 (EDT) From: Gregory Haskins Subject: [PATCH 1/3] eventfd: Allow waiters to be notified about the eventfd file* going away To: davidel@xmailserver.org Cc: mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com, paulmck@linux.vnet.ibm.com, mingo@elte.hu Date: Fri, 19 Jun 2009 14:51:27 -0400 Message-ID: <20090619185127.31118.2893.stgit@dev.haskins.net> In-Reply-To: <20090619183534.31118.30934.stgit@dev.haskins.net> References: <20090619183534.31118.30934.stgit@dev.haskins.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Davide Libenzi And give them a change to unregister from the wait queue. This is turn allows eventfd users to use the eventfd file* w/out holding a live reference to it. After the eventfd user callbacks returns, any usage of the eventfd file* should be dropped. The eventfd user callback can acquire sleepy locks since it is invoked lockless. This is a feature, needed by KVM to avoid an awkward workaround when using eventfd. Signed-off-by: Davide Libenzi Tested-by: Gregory Haskins Signed-off-by: Andrew Morton Signed-off-by: Gregory Haskins Signed-off-by: Avi Kivity --- fs/eventfd.c | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/eventfd.c b/fs/eventfd.c index 2a701d5..c71f51d 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -59,7 +59,15 @@ int eventfd_signal(struct file *file, int n) static int eventfd_release(struct inode *inode, struct file *file) { - kfree(file->private_data); + struct eventfd_ctx *ctx = file->private_data; + + /* + * No need to hold the lock here, since we are on the file cleanup + * path and the ones still attached to the wait queue will be + * serialized by wake_up_locked_poll(). + */ + wake_up_locked_poll(&ctx->wqh, POLLHUP); + kfree(ctx); return 0; }