From patchwork Sun Jul 5 11:40:57 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 34124 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n65BfeCF022132 for ; Sun, 5 Jul 2009 11:41:40 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbZGELlf (ORCPT ); Sun, 5 Jul 2009 07:41:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754345AbZGELlf (ORCPT ); Sun, 5 Jul 2009 07:41:35 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39170 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754246AbZGELle (ORCPT ); Sun, 5 Jul 2009 07:41:34 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n65Bfa6u013640; Sun, 5 Jul 2009 07:41:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n65BfZGP008671; Sun, 5 Jul 2009 07:41:35 -0400 Received: from redhat.com (vpn-6-125.tlv.redhat.com [10.35.6.125]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n65BfWaN010142; Sun, 5 Jul 2009 07:41:33 -0400 Date: Sun, 5 Jul 2009 14:40:57 +0300 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org, aliguori@us.ibm.com, kwolf@redhat.com, glommer@redhat.com, blauwirbel@gmail.com Subject: [PATCHv4 4/5] qemu/msi: missing braces Message-ID: <20090705114057.GE4798@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org MSIX present bit is tested incorrectly, and only happens to work because the bit we are testing is 0x1. Add braces to fix this. Reported-by: Blue Swirl Signed-off-by: Michael S. Tsirkin --- hw/msix.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 33549f5..db72cc3 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f) { unsigned n = dev->msix_entries_nr; - if (!dev->cap_present & QEMU_PCI_CAP_MSIX) + if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) return; msix_free_irq_entries(dev);