From patchwork Tue May 18 11:33:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 100410 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4IBbPF7009823 for ; Tue, 18 May 2010 11:37:26 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200Ab0ERLhX (ORCPT ); Tue, 18 May 2010 07:37:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61466 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059Ab0ERLhX (ORCPT ); Tue, 18 May 2010 07:37:23 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4IBbD2d028150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 May 2010 07:37:13 -0400 Received: from redhat.com (vpn2-11-116.ams2.redhat.com [10.36.11.116]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id o4IBbBrA010337; Tue, 18 May 2010 07:37:11 -0400 Date: Tue, 18 May 2010 14:33:17 +0300 From: "Michael S. Tsirkin" To: Rusty Russell Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org Subject: Re: virtio: imply disable_cb on callbacks Message-ID: <20100518113316.GA26757@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 18 May 2010 11:37:26 +0000 (UTC) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -69,6 +69,8 @@ static void blk_done(struct virtqueue *v /* In case queue is stopped waiting for more buffers. */ blk_start_queue(vblk->disk->queue); spin_unlock_irqrestore(&vblk->lock, flags); + + vq->vq_ops->enable_cb(vq); } static bool do_req(struct request_queue *q, struct virtio_blk *vblk,