From patchwork Wed May 25 02:24:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amos Kong X-Patchwork-Id: 814702 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p4P2MR9i016954 for ; Wed, 25 May 2011 02:22:28 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445Ab1EYCWZ (ORCPT ); Tue, 24 May 2011 22:22:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7912 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177Ab1EYCWY (ORCPT ); Tue, 24 May 2011 22:22:24 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4P2MO66010064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 May 2011 22:22:24 -0400 Received: from [127.0.0.1] (dhcp-8-167.nay.redhat.com [10.66.8.167]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4P2MLOZ002548; Tue, 24 May 2011 22:22:22 -0400 Subject: [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments To: autotest@test.kernel.org From: Amos Kong Cc: lmr@redhat.com, amwang@redhat.com, kvm@vger.kernel.org Date: Wed, 25 May 2011 10:24:49 +0800 Message-ID: <20110525022449.3264.49173.stgit@t> In-Reply-To: References: User-Agent: StGit/0.15 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 25 May 2011 02:22:28 +0000 (UTC) Appended kernel cmdline should be involved by quotation marks. -append 'root=/dev/vda ro ..' Reported-by: Cong Wang Signed-off-by: Amos Kong --- client/virt/kvm_vm.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py index c9bb273..343488f 100644 --- a/client/virt/kvm_vm.py +++ b/client/virt/kvm_vm.py @@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM): return " -initrd '%s'" % filename def add_kernel_cmdline(help, cmdline): - return " -append %s" % cmdline + return " -append '%s'" % cmdline def add_testdev(help, filename): return (" -chardev file,id=testlog,path=%s"