From patchwork Tue Jun 7 13:09:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amos Kong X-Patchwork-Id: 856522 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p57DA2El028022 for ; Tue, 7 Jun 2011 13:10:02 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754698Ab1FGNJw (ORCPT ); Tue, 7 Jun 2011 09:09:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39711 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754631Ab1FGNJv (ORCPT ); Tue, 7 Jun 2011 09:09:51 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p57D9m0O030741 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Jun 2011 09:09:48 -0400 Received: from localhost (vpn1-7-27.sin2.redhat.com [10.67.7.27]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p57D9kAe023060; Tue, 7 Jun 2011 09:09:47 -0400 Date: Tue, 7 Jun 2011 21:09:42 +0800 From: Amos Kong To: rusty@rustcorp.com.au Cc: kvm@vger.kernel.org Subject: [PATCH v2] virtio-spec: Fix wrong bit number of device status Message-ID: <20110607130942.GA16234@t400> Reply-To: Amos Kong References: <1307451139-20613-1-git-send-email-akong@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1307451139-20613-1-git-send-email-akong@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 07 Jun 2011 13:10:02 +0000 (UTC) qemu-kvm/hw/virtio_config.h: #define VIRTIO_CONFIG_S_ACKNOWLEDGE 1 #define VIRTIO_CONFIG_S_DRIVER 2 #define VIRTIO_CONFIG_S_DRIVER_OK 4 #define VIRTIO_CONFIG_S_FAILED 0x80 virtio-spec: ACKNOWLEDGE(1) : DRIVER(2) : DRIVER_OK(3) : FAILED(128) : The spec refers to bit numbers and the headers use absolute numbers, they are not consistent. it shoule be 'FAILED(8)'. 2^(8-1) = 128 Changes from V1: - Fix wrong patch body Signed-off-by: Amos Kong --- virtio-spec.lyx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 448af76..1fc3e59 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -1552,7 +1552,7 @@ FAILED \begin_inset space ~ \end_inset -(128) Indicates that something went wrong in the guest, and it has given +(8) Indicates that something went wrong in the guest, and it has given up on the device. This could be an internal error, or the driver didn't like the device for some reason, or even a fatal error during device operation.