From patchwork Thu Jun 16 02:10:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amos Kong X-Patchwork-Id: 883922 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5G2AM5h026690 for ; Thu, 16 Jun 2011 02:10:23 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754762Ab1FPCKS (ORCPT ); Wed, 15 Jun 2011 22:10:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57801 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998Ab1FPCKS (ORCPT ); Wed, 15 Jun 2011 22:10:18 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5G2AGSd013622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Jun 2011 22:10:16 -0400 Received: from localhost6.localdomain6 ([10.66.9.169]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5G2AD7W016833; Wed, 15 Jun 2011 22:10:14 -0400 Subject: [PATCH v2] virtio: Define queue_size to unsigned To: qemu-devel@nongnu.org From: Amos Kong Cc: kvm@vger.kernel.org, mst@redhat.com Date: Thu, 16 Jun 2011 10:10:13 +0800 Message-ID: <20110616021013.4160.89565.stgit@localhost6.localdomain6> In-Reply-To: <4DF940E3.2020603@codemonkey.ws> References: <4DF940E3.2020603@codemonkey.ws> User-Agent: StGit/0.15 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 16 Jun 2011 02:10:23 +0000 (UTC) It's not valid for queue_size to be negative, then the type ought to be unsigned. Changes from V1: - drop the check and just define it to unsigned. Signed-off-by: Amos Kong --- hw/virtio.c | 2 +- hw/virtio.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/hw/virtio.c b/hw/virtio.c index 6e8814c..4c1e334 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -602,7 +602,7 @@ void virtio_queue_set_vector(VirtIODevice *vdev, int n, uint16_t vector) vdev->vq[n].vector = vector; } -VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size, +VirtQueue *virtio_add_queue(VirtIODevice *vdev, unsigned int queue_size, void (*handle_output)(VirtIODevice *, VirtQueue *)) { int i; diff --git a/hw/virtio.h b/hw/virtio.h index bc72289..ff0c9b5 100644 --- a/hw/virtio.h +++ b/hw/virtio.h @@ -138,7 +138,7 @@ static inline void virtio_set_status(VirtIODevice *vdev, uint8_t val) vdev->status = val; } -VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size, +VirtQueue *virtio_add_queue(VirtIODevice *vdev, unsigned int queue_size, void (*handle_output)(VirtIODevice *, VirtQueue *));