| Message ID | 20120629155622.30535.24831.stgit@bling.home (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 29, 2012 at 09:56:24AM -0600, Alex Williamson wrote: > We only know of one so far. > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> BTW should we sanitize padding as well? > --- > > virt/kvm/eventfd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index c307c24..7d7e2aa 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -340,6 +340,9 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args) > int > kvm_irqfd(struct kvm *kvm, struct kvm_irqfd *args) > { > + if (args->flags & ~KVM_IRQFD_FLAG_DEASSIGN) > + return -EINVAL; > + > if (args->flags & KVM_IRQFD_FLAG_DEASSIGN) > return kvm_irqfd_deassign(kvm, args); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 2012-07-01 at 11:26 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 29, 2012 at 09:56:24AM -0600, Alex Williamson wrote: > > We only know of one so far. > > > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> > > BTW should we sanitize padding as well? I imagine that to make use of a field in the padding we'll set a bit in the flags to indicate that the field is present/valid. That way we don't care about garbage in the padding as long as we can sanitize the flags. Thanks, Alex > > --- > > > > virt/kvm/eventfd.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > > index c307c24..7d7e2aa 100644 > > --- a/virt/kvm/eventfd.c > > +++ b/virt/kvm/eventfd.c > > @@ -340,6 +340,9 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args) > > int > > kvm_irqfd(struct kvm *kvm, struct kvm_irqfd *args) > > { > > + if (args->flags & ~KVM_IRQFD_FLAG_DEASSIGN) > > + return -EINVAL; > > + > > if (args->flags & KVM_IRQFD_FLAG_DEASSIGN) > > return kvm_irqfd_deassign(kvm, args); > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index c307c24..7d7e2aa 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -340,6 +340,9 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args) int kvm_irqfd(struct kvm *kvm, struct kvm_irqfd *args) { + if (args->flags & ~KVM_IRQFD_FLAG_DEASSIGN) + return -EINVAL; + if (args->flags & KVM_IRQFD_FLAG_DEASSIGN) return kvm_irqfd_deassign(kvm, args);
We only know of one so far. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> --- virt/kvm/eventfd.c | 3 +++ 1 file changed, 3 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html