From patchwork Thu Jul 26 12:22:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Trippelsdorf X-Patchwork-Id: 1242431 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 75165DFFBF for ; Thu, 26 Jul 2012 12:23:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767Ab2GZMWx (ORCPT ); Thu, 26 Jul 2012 08:22:53 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:34339 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266Ab2GZMWw (ORCPT ); Thu, 26 Jul 2012 08:22:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h= date:from:to:cc:subject:message-id:mime-version:content-type; s= beta; bh=ya/H4IiFjxIyaegmsKh37b/EKhxbgpxw/f3RnR6BrMo=; b=VhyuvNI x/XUmOIJENY1w+B/W1oPy8XKOhy2qoFxjgqkw6x9UUfeIsal7Iz/OyErtr4EvI8D QNizHtHrYyXkTWfj0J2iNNNLFcpjWDFXuHG95GP5ZsGKQrQ32xLos/hCpE+sd2/G 1gN12JRUMperXU4JO4CU+HQLs0pls1zdTVRc= Received: (qmail 10164 invoked from network); 26 Jul 2012 14:22:49 +0200 Received: from unknown (HELO x4) (ud10?360p3@91.64.56.160) by mail.ud10.udmedia.de with ESMTPSA (DHE-RSA-AES256-SHA encrypted, authenticated); 26 Jul 2012 14:22:49 +0200 Date: Thu, 26 Jul 2012 14:22:48 +0200 From: Markus Trippelsdorf To: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Avi Kivity , Marcelo Tosatti Subject: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set Message-ID: <20120726122248.GA252@x4> MIME-Version: 1.0 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Every time I start qemu-kvm on my system the following line is added to the syslog: vcpu0 unhandled rdmsr: 0xc0010001 AFAICS all calls to vcpu_unimpl only contain debugging info with little or no value for the end user. Wouldn't something like the following patch make sense? Signed-off-by: Markus Trippelsdorf diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index b70b48b..6bd816f 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -321,7 +321,7 @@ struct kvm { #define kvm_debug(fmt, ...) \ pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__) #define kvm_pr_unimpl(fmt, ...) \ - pr_err_ratelimited("kvm [%i]: " fmt, \ + pr_debug_ratelimited("kvm [%i]: " fmt, \ task_tgid_nr(current), ## __VA_ARGS__) /* The guest did something we don't support. */