From patchwork Tue Jul 22 17:28:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Schopp X-Patchwork-Id: 4604331 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DEAD2C0514 for ; Tue, 22 Jul 2014 17:28:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 12F9620158 for ; Tue, 22 Jul 2014 17:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1880E20103 for ; Tue, 22 Jul 2014 17:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129AbaGVR2V (ORCPT ); Tue, 22 Jul 2014 13:28:21 -0400 Received: from mail-by2lp0239.outbound.protection.outlook.com ([207.46.163.239]:25464 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755655AbaGVR2U (ORCPT ); Tue, 22 Jul 2014 13:28:20 -0400 Received: from BLUPR02CA059.namprd02.prod.outlook.com (25.160.23.177) by BN1PR02MB037.namprd02.prod.outlook.com (10.242.210.147) with Microsoft SMTP Server (TLS) id 15.0.990.7; Tue, 22 Jul 2014 17:28:17 +0000 Received: from BN1BFFO11FD052.protection.gbl (2a01:111:f400:7c10::1:110) by BLUPR02CA059.outlook.office365.com (2a01:111:e400:8ad::49) with Microsoft SMTP Server (TLS) id 15.0.990.7 via Frontend Transport; Tue, 22 Jul 2014 17:28:17 +0000 Received: from atltwp02.amd.com (165.204.84.222) by BN1BFFO11FD052.mail.protection.outlook.com (10.58.145.7) with Microsoft SMTP Server id 15.0.980.11 via Frontend Transport; Tue, 22 Jul 2014 17:28:16 +0000 X-WSS-ID: 0N94J72-08-COG-02 X-M-MSG: Received: from satlvexedge01.amd.com (satlvexedge01.amd.com [10.177.96.28]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by atltwp02.amd.com (Axway MailGate 5.3.1) with ESMTPS id 23814D16003; Tue, 22 Jul 2014 12:28:14 -0500 (CDT) Received: from SATLEXDAG03.amd.com (10.181.40.7) by satlvexedge01.amd.com (10.177.96.28) with Microsoft SMTP Server (TLS) id 14.2.328.9; Tue, 22 Jul 2014 12:28:25 -0500 Received: from joelaarch64.amd.com (10.180.168.240) by satlexdag03.amd.com (10.181.40.7) with Microsoft SMTP Server (TLS) id 14.2.328.9; Tue, 22 Jul 2014 13:28:14 -0400 Subject: [PATCH] kvmtool: arm64: fix compilation error From: Joel Schopp To: , , CC: Pekka Enberg Date: Tue, 22 Jul 2014 12:28:09 -0500 Message-ID: <20140722172809.4939.92258.stgit@joelaarch64.amd.com> User-Agent: StGit/0.17.1-4-g4a0c1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222; CTRY:US; IPV:NLI; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(6009001)(428002)(199002)(189002)(47776003)(107046002)(74502001)(92566001)(68736004)(103116003)(2201001)(81342001)(31966008)(80022001)(20776003)(105586002)(85852003)(102836001)(64706001)(97746001)(19580395003)(2171001)(92726001)(53416004)(99396002)(50466002)(77096002)(81542001)(83322001)(4396001)(85306003)(86362001)(76482001)(77982001)(87936001)(106466001)(19580405001)(74662001)(46102001)(54356999)(79102001)(83072002)(97736001)(229853001)(33646002)(95666004)(83506001)(44976005)(23676002)(84676001)(21056001)(101416001)(50986999)(71626003); DIR:OUT; SFP:; SCL:1; SRVR:BN1PR02MB037; H:atltwp02.amd.com; FPR:; MLV:nov; PTR:InfoDomainNonexistent; MX:1; LANG:en; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID: X-Forefront-PRVS: 02801ACE41 Received-SPF: None (: amd.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Joel.Schopp@amd.com; X-OriginatorOrg: amd4.onmicrosoft.com Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently tools/kvm doesn't build on arm64 when gtk3 is present. The error looks like this: LINK lkvm ui/gtk3.o: In function `kvm_gtk_key_press': /extra/sb/linux-kvm/tools/kvm/ui/gtk3.c:201: undefined reference to `kbd_queue' /extra/sb/linux-kvm/tools/kvm/ui/gtk3.c:204: undefined reference to `kbd_queue' /extra/sb/linux-kvm/tools/kvm/ui/gtk3.c:216: undefined reference to `kbd_queue' /extra/sb/linux-kvm/tools/kvm/ui/gtk3.c:217: undefined reference to `kbd_queue' /extra/sb/linux-kvm/tools/kvm/ui/gtk3.c:218: undefined reference to `kbd_queue' ui/gtk3.o:/extra/sb/linux-kvm/tools/kvm/ui/gtk3.c:219: more undefined references to `kbd_queue' follow collect2: error: ld returned 1 exit status make: *** [lkvm] Error 1 The patch below makes the error go away and the resulting lkvm runs on arm64. Cc: Pekka Enberg Signed-off-by: Joel Schopp --- tools/kvm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile index 880d580..fba60f1 100644 --- a/tools/kvm/Makefile +++ b/tools/kvm/Makefile @@ -102,6 +102,7 @@ OBJS += hw/pci-shmem.o OBJS += kvm-ipc.o OBJS += builtin-sandbox.o OBJS += virtio/mmio.o +OBJS += hw/i8042.o # Translate uname -m into ARCH string ARCH ?= $(shell uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/ \ @@ -129,7 +130,6 @@ ifeq ($(ARCH),x86) OBJS += x86/kvm.o OBJS += x86/kvm-cpu.o OBJS += x86/mptable.o - OBJS += hw/i8042.o # Exclude BIOS object files from header dependencies. OTHEROBJS += x86/bios.o OTHEROBJS += x86/bios/bios-rom.o