From patchwork Wed Mar 11 19:19:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin O'Connor X-Patchwork-Id: 5988401 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 497B89F380 for ; Wed, 11 Mar 2015 19:19:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 69640203B0 for ; Wed, 11 Mar 2015 19:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AAC420383 for ; Wed, 11 Mar 2015 19:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434AbbCKTTb (ORCPT ); Wed, 11 Mar 2015 15:19:31 -0400 Received: from mail-qg0-f41.google.com ([209.85.192.41]:35134 "EHLO mail-qg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbbCKTTb (ORCPT ); Wed, 11 Mar 2015 15:19:31 -0400 Received: by qgfh3 with SMTP id h3so12638735qgf.2 for ; Wed, 11 Mar 2015 12:19:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=3Cu2cB+ug3aVPnmlxer+UNhGDxxjriri4MH7FqwQfFI=; b=B1gKPOfDn8GoPnNXp1n1DKZ72zouuDahpp1gN8lO90q7bjs2hAs3i7fZ5umE3X12ua Qj+EQC9GLVlaC23HN02aF13spBfRymG0lmxom0LunMrG14U/aE657+XQsxwqzHxxBMDO zD0Vqg2Oh0X13GSowy248jsEuhZdyAjApcMhMEyKxj+TdWyL/fHy8fDZJZL4YZCqiofE WR/3UeJzyVD/iiR+VSJuQVg+vWPz9s+81H4v9lNBv6akEySfxIQ/G8ZSAIJIX0IQGWmw Pu0q1dqe55bYCwafW3ij5AuLZbQkJ0Ht/H4LWFjb8IStSLvqHaIj6s7rdFqxY9lzk6ke Qcgg== X-Gm-Message-State: ALoCoQkFnen9TKwTBDkGOIKv34Ld9ahpovGqrICqQgRoK4tc2NUeTXgS2z/Hhu7iUo3KTzoaJWDm X-Received: by 10.140.239.140 with SMTP id k134mr6745768qhc.98.1426101570339; Wed, 11 Mar 2015 12:19:30 -0700 (PDT) Received: from localhost (207-172-170-53.c3-0.avec-ubr1.nyr-avec.ny.cable.rcn.com. [207.172.170.53]) by mx.google.com with ESMTPSA id 21sm3162375qgi.36.2015.03.11.12.19.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Mar 2015 12:19:29 -0700 (PDT) Date: Wed, 11 Mar 2015 15:19:28 -0400 From: Kevin O'Connor To: "Dr. David Alan Gilbert" Cc: Bandan Das , Paolo Bonzini , kraxel@redhat.com, Andrey Korolyov , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" Subject: Re: [Qemu-devel] E5-2620v2 - emulation stop error Message-ID: <20150311191928.GA14695@morn.localdomain> References: <20150311134556.GH2334@work-vm> <20150311154220.GA26463@morn.localdomain> <20150311155306.GK2334@work-vm> <20150311163739.GA29522@morn.localdomain> <20150311165203.GL2334@work-vm> <20150311173738.GD29522@morn.localdomain> <20150311175904.GN2334@work-vm> <20150311184039.GA7341@morn.localdomain> <20150311184531.GA11423@morn.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150311184531.GA11423@morn.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Mar 11, 2015 at 02:45:31PM -0400, Kevin O'Connor wrote: > On Wed, Mar 11, 2015 at 02:40:39PM -0400, Kevin O'Connor wrote: > > For what it's worth, I can't seem to trigger the problem if I move the > > cmos read above the SIPI/LAPIC code (see patch below). > > Ugh! > > That's a seabios bug. Main processor modifies the rtc index > (rtc_read()) while APs try to clear the NMI bit by modifying the rtc > index (romlayout.S:transition32). > > I'll put together a fix. The seabios patch below resolves the issue for me. -Kevin --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/src/romlayout.S +++ b/src/romlayout.S @@ -22,7 +22,8 @@ // %edx = return location (in 32bit mode) // Clobbers: ecx, flags, segment registers, cr0, idt/gdt DECLFUNC transition32 -transition32_for_smi: +transition32_nmi_off: + // transition32 when NMI and A20 are already initialized movl %eax, %ecx jmp 1f transition32: @@ -205,7 +206,7 @@ __farcall16: entry_smi: // Transition to 32bit mode. movl $1f + BUILD_BIOS_ADDR, %edx - jmp transition32_for_smi + jmp transition32_nmi_off .code32 1: movl $BUILD_SMM_ADDR + 0x8000, %esp calll _cfunc32flat_handle_smi - BUILD_BIOS_ADDR @@ -216,8 +217,10 @@ entry_smi: DECLFUNC entry_smp entry_smp: // Transition to 32bit mode. + cli + cld movl $2f + BUILD_BIOS_ADDR, %edx - jmp transition32 + jmp transition32_nmi_off .code32 // Acquire lock and take ownership of shared stack 1: rep ; nop