From patchwork Tue Sep 1 10:04:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Trippelsdorf X-Patchwork-Id: 7104461 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DD2D69F36E for ; Tue, 1 Sep 2015 10:11:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ED03420416 for ; Tue, 1 Sep 2015 10:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F126820411 for ; Tue, 1 Sep 2015 10:11:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755420AbbIAKK7 (ORCPT ); Tue, 1 Sep 2015 06:10:59 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:50714 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755271AbbIAKK7 (ORCPT ); Tue, 1 Sep 2015 06:10:59 -0400 X-Greylist: delayed 398 seconds by postgrey-1.27 at vger.kernel.org; Tue, 01 Sep 2015 06:10:58 EDT DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=beta; bh=+dK2iE0dX3Yz2rwk3cDoN2JQKx CTLjKmF9nVzt+7iP0=; b=qQsQsepRVvqDIAE6t7ATveZr8eVEYd8WR4i8IkclxL duCJ1R5RNMAb+CjmefvJF5ONPs+Ns4KqUymc+6+YsgbZSLdDXL+2sdg9qSayEe8j 6EH9LK8sVeVAuI2ovR3MP5/FyktiDhJcvp0oMVutX+Fp81qdtKT707AIsRQS6BR+ c= Received: (qmail 21317 invoked from network); 1 Sep 2015 12:04:17 +0200 Received: from ip5b41f88a.dynamic.kabel-deutschland.de (HELO x4) (ud10?360p3@91.65.248.138) by mail.ud10.udmedia.de with ESMTPSA (ECDHE-RSA-AES256-SHA encrypted, authenticated); 1 Sep 2015 12:04:17 +0200 Date: Tue, 1 Sep 2015 12:04:17 +0200 From: Markus Trippelsdorf To: Ingo Molnar Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , Andrew Morton , Mike Galbraith , Joerg Roedel , Paolo Bonzini , kvm@vger.kernel.org Subject: Re: commit 3c2e7f7de3 (KVM use NPT page attributes) causes boot failures Message-ID: <20150901100417.GA424@x4> References: <20150831172453.GA5429@gmail.com> <20150901070856.GA430@x4> <20150901072741.GB20383@gmail.com> <20150901074449.GB430@x4> <20150901083856.GD25398@gmail.com> <20150901084444.GB421@x4> <20150901085627.GF6315@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150901085627.GF6315@gmail.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 2015.09.01 at 10:56 +0200, Ingo Molnar wrote: > > * Markus Trippelsdorf wrote: > > As I wrote in my other reply. The boot failure is nondeterministic (boot > > succeeds roughly every sixth time). So the bisection and the patch is > > just bogus (,but the boot failure is real). > > > > Sorry. > > No problem. Please let us know if any of these commits does turn out to be the > culprit. (Which is always a possibility.) I'm pretty sure commit 3c2e7f7de3 is the culprit. commit 3c2e7f7de3240216042b61073803b61b9b3cfb22 Author: Paolo Bonzini Date: Tue Jul 7 14:32:17 2015 +0200 KVM: SVM: use NPT page attributes I've booted ten times in a row successfully with the following patch: Paolo, your commit causes nondeterministic boot failure on my machine. It sometimes crashes early with the following backtrace: map_vsyscall kvm_arch_hardware_setup map_vsyscall kvm_init map_vsyscall do_one_initcall kernel_init_freeable rest_init kernel_init ret_from_fork rest_init RIP: svm_hardware_setup diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 74d825716f4f..3190173a575f 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -989,7 +989,7 @@ static __init int svm_hardware_setup(void) } else kvm_disable_tdp(); - build_mtrr2protval(); +// build_mtrr2protval(); return 0; err: