From patchwork Thu Feb 14 10:47:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 10812411 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88A2613A4 for ; Thu, 14 Feb 2019 10:48:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75B362D6AD for ; Thu, 14 Feb 2019 10:48:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 69FC12D6B0; Thu, 14 Feb 2019 10:48:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D4DE2D6AD for ; Thu, 14 Feb 2019 10:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405458AbfBNKsD (ORCPT ); Thu, 14 Feb 2019 05:48:03 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:38933 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395333AbfBNKsC (ORCPT ); Thu, 14 Feb 2019 05:48:02 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N8oKc-1h6zsz3YhS-015q5Y; Thu, 14 Feb 2019 11:47:48 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Laurent Vivier , Paolo Bonzini , kvm@vger.kernel.org, libvir-list@redhat.com, "Michael S. Tsirkin" , Eric Blake , Markus Armbruster , Michael Tokarev , "Dr. David Alan Gilbert" , qemu-trivial@nongnu.org, Gerd Hoffmann , Artyom Tarasenko , Kamil Rytarowski , Mark Cave-Ayland , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Thomas Huth , Stefano Garzarella Subject: [PULL 12/14] hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf Date: Thu, 14 Feb 2019 11:47:15 +0100 Message-Id: <20190214104717.3543-13-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190214104717.3543-1-laurent@vivier.eu> References: <20190214104717.3543-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:J7mRyDYOD38Kb3OrYj08T2sfYhUIjMhl4UqoH6czZ6hT9NXGNtt kqXDpIeez85B2GBLctlGjNTnGUOcTE7p0VADhje7S+yvOebE9THy/yajPyR9zjRE+UXC4yk 7CrrF8kLILUsfRSr/Bn8xDBRbNU3KL7yu4nVPJ4K4KRx0cvSZoXJ0OcqMHX3SJQu1EBKRmG eTu7l4QVztPUdmGdjXiNw== X-UI-Out-Filterresults: notjunk:1;V03:K0:rISYavrEtlY=:tpboYl/9rmZkb376tj8du/ o5WeGRlCXorHltLufOp7j1P7cYCigSHkirttjVuBhh6OiQRqG1WW2xfK6K929BZXTVx0FA9TT PTSRXWVP1CwhR6IFgH1+qros9O7igXeiqK1ThH4RipccdhYJVIYHIdO/GK8VWNw0334fbWAT8 CcXV/iQoB6qNavh66Osz2f9FHL8rIRbL2+mdwiXskxZqPwflEVWkMCb13nMPlXnqO8JALA4Qc +ZIjcleMJcxVGB9OkunACDGkocLlv+fiHGBjYRmB5CP6M8H3Q1AxkYprjIw3EhlTUgiO43OEP AB2WCjwox3A+INJ3CDjrTFlXXlzoOuPDiJDeYNpp4HF7jrTktxTxNWsUek3BSzDC13StPJPx+ PYV14Q53wpCpWCu1hIy/Sv6cLyq9qIbZ7SjTZTwF3frqs6loe0ISesDQBO3/WXasFiPZpjDSQ mhmOQrt4TsmYYCUTmVd1avjCVJiZLAlt6MrovXXuLWTRndbD63mdkeq97kUAGpoDIvEiJPMPL D7X9iBvheEaS+dq9pJj3ksrrjUhQvO4T+xId4xau9YU26R+NkVMldPzQV6slfegbXDV/HMXDa PkkyowGwBLl4Z8IvQgfEGJ4OMtVYPrmKm6dH0ljFXMXzmPo+eCPB7zCf6M6+fBJyEBcfdfI6B 56Kd0tc1FmKDT9PJWFWOPE3M9hfgHVVilFHeCkFqB9u7p6RLkOHRJl1gSv5egDc5CJRfZQWrF UMWhdIAczpMkHsoeKd4/lrTccP1QGk8nThhCtEW07xgXkRkPo2kDZhAOhJo= Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Philippe Mathieu-Daudé Avoid to clutter stdout until explicitly requested (with -d unimp): $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin dma: command df not supported dma: command df not supported dma: command df not supported dma: command df not supported Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Stefano Garzarella Message-Id: <20190212145322.30974-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/dma/i8257.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index 52675e97c9e7..3e1f13a4aaf4 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@ -26,6 +26,7 @@ #include "hw/isa/isa.h" #include "hw/dma/i8257.h" #include "qemu/main-loop.h" +#include "qemu/log.h" #include "trace.h" #define I8257(obj) \ @@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data, switch (iport) { case 0x00: /* command */ if ((data != 0) && (data & CMD_NOT_SUPPORTED)) { - dolog("command %"PRIx64" not supported\n", data); + qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n", + __func__, data); return; } d->command = data;