| Message ID | 20190624090721.16241-1-cohuck@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio-ccw: make convert_ccw0_to_ccw1 static | expand |
On 24.06.19 11:07, Cornelia Huck wrote: > Reported by sparse. > > Fixes: 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition") > Signed-off-by: Cornelia Huck <cohuck@redhat.com> > --- > On top of my vfio-ccw branch. > > s390 arch maintainers: let me know if I should queue it and send > a pull request, or if you prefer to apply it directly. I still have to sort out some tooling for the s390 tree and I applied it directly. Thanks > --- > drivers/s390/cio/vfio_ccw_cp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c > index 9cddc1288059..a7b9dfd5b464 100644 > --- a/drivers/s390/cio/vfio_ccw_cp.c > +++ b/drivers/s390/cio/vfio_ccw_cp.c > @@ -161,7 +161,7 @@ static inline void pfn_array_idal_create_words( > idaws[0] += pa->pa_iova & (PAGE_SIZE - 1); > } > > -void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len) > +static void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len) > { > struct ccw0 ccw0; > struct ccw1 *pccw1 = source; >
diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c index 9cddc1288059..a7b9dfd5b464 100644 --- a/drivers/s390/cio/vfio_ccw_cp.c +++ b/drivers/s390/cio/vfio_ccw_cp.c @@ -161,7 +161,7 @@ static inline void pfn_array_idal_create_words( idaws[0] += pa->pa_iova & (PAGE_SIZE - 1); } -void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len) +static void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len) { struct ccw0 ccw0; struct ccw1 *pccw1 = source;
Reported by sparse. Fixes: 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition") Signed-off-by: Cornelia Huck <cohuck@redhat.com> --- On top of my vfio-ccw branch. s390 arch maintainers: let me know if I should queue it and send a pull request, or if you prefer to apply it directly. --- drivers/s390/cio/vfio_ccw_cp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)