diff mbox series

[kvm-unit-tests] s390x: unittests: Use smp parameter

Message ID 20200213143855.2965-1-drjones@redhat.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests] s390x: unittests: Use smp parameter | expand

Commit Message

Andrew Jones Feb. 13, 2020, 2:38 p.m. UTC
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 s390x/unittests.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Hildenbrand Feb. 13, 2020, 2:42 p.m. UTC | #1
On 13.02.20 15:38, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  s390x/unittests.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
> index 07013b2b8748..aa6d5d96e292 100644
> --- a/s390x/unittests.cfg
> +++ b/s390x/unittests.cfg
> @@ -74,7 +74,7 @@ file = stsi.elf
>  
>  [smp]
>  file = smp.elf
> -extra_params =-smp 2
> +smp = 2
>  
>  [sclp-1g]
>  file = sclp.elf
> 

Reviewed-by: David Hildenbrand <david@redhat.com>
Janosch Frank Feb. 13, 2020, 3:08 p.m. UTC | #2
On 2/13/20 3:38 PM, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  s390x/unittests.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
> index 07013b2b8748..aa6d5d96e292 100644
> --- a/s390x/unittests.cfg
> +++ b/s390x/unittests.cfg
> @@ -74,7 +74,7 @@ file = stsi.elf
>  
>  [smp]
>  file = smp.elf
> -extra_params =-smp 2
> +smp = 2
>  

That should've been part of the VMM patchset?

Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

>  [sclp-1g]
>  file = sclp.elf
>
Andrew Jones Feb. 13, 2020, 4:42 p.m. UTC | #3
On Thu, Feb 13, 2020 at 04:08:30PM +0100, Janosch Frank wrote:
> On 2/13/20 3:38 PM, Andrew Jones wrote:
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> >  s390x/unittests.cfg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
> > index 07013b2b8748..aa6d5d96e292 100644
> > --- a/s390x/unittests.cfg
> > +++ b/s390x/unittests.cfg
> > @@ -74,7 +74,7 @@ file = stsi.elf
> >  
> >  [smp]
> >  file = smp.elf
> > -extra_params =-smp 2
> > +smp = 2
> >  
> 
> That should've been part of the VMM patchset?

I sent it separately because it's not really related. I did find it
while doing the VMM patchset though.

> 
> Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

Thanks,
drew

> 
> >  [sclp-1g]
> >  file = sclp.elf
> > 
> 
>
diff mbox series

Patch

diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
index 07013b2b8748..aa6d5d96e292 100644
--- a/s390x/unittests.cfg
+++ b/s390x/unittests.cfg
@@ -74,7 +74,7 @@  file = stsi.elf
 
 [smp]
 file = smp.elf
-extra_params =-smp 2
+smp = 2
 
 [sclp-1g]
 file = sclp.elf