diff mbox series

KVM: SVM: Do not setup frame pointer in __svm_vcpu_run

Message ID 20200409120440.1427215-1-ubizjak@gmail.com (mailing list archive)
State New, archived
Headers show
Series KVM: SVM: Do not setup frame pointer in __svm_vcpu_run | expand

Commit Message

Uros Bizjak April 9, 2020, 12:04 p.m. UTC 
__svm_vcpu_run is a leaf function and does not need
a frame pointer.  %rbp is also destroyed a few instructions
later when guest registers are loaded.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
---
 arch/x86/kvm/svm/vmenter.S | 1 -
 1 file changed, 1 deletion(-)

Comments

Paolo Bonzini April 15, 2020, 3:41 p.m. UTC | #1 
On 09/04/20 14:04, Uros Bizjak wrote:
> __svm_vcpu_run is a leaf function and does not need
> a frame pointer.  %rbp is also destroyed a few instructions
> later when guest registers are loaded.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> ---
>  arch/x86/kvm/svm/vmenter.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/svm/vmenter.S b/arch/x86/kvm/svm/vmenter.S
> index fa1af90067e9..c87119a7a0c9 100644
> --- a/arch/x86/kvm/svm/vmenter.S
> +++ b/arch/x86/kvm/svm/vmenter.S
> @@ -35,7 +35,6 @@
>   */
>  SYM_FUNC_START(__svm_vcpu_run)
>  	push %_ASM_BP
> -	mov  %_ASM_SP, %_ASM_BP
>  #ifdef CONFIG_X86_64
>  	push %r15
>  	push %r14
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/arch/x86/kvm/svm/vmenter.S b/arch/x86/kvm/svm/vmenter.S
index fa1af90067e9..c87119a7a0c9 100644
--- a/arch/x86/kvm/svm/vmenter.S
+++ b/arch/x86/kvm/svm/vmenter.S
@@ -35,7 +35,6 @@ 
  */
 SYM_FUNC_START(__svm_vcpu_run)
 	push %_ASM_BP
-	mov  %_ASM_SP, %_ASM_BP
 #ifdef CONFIG_X86_64
 	push %r15
 	push %r14