| Message ID | 20200520181240.118559-2-mlevitsk@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RFC: Make thunderbolt NHI driver work with kexec | expand |
On Wed, 2020-05-20 at 21:12 +0300, Maxim Levitsky wrote: > On my machine, a kexec with this driver loaded in the old kernel > causes a very long delay on boot in the kexec'ed kernel, > most likely due to unclean shutdown prior to that. > > Unloading thunderbolt driver prior to kexec allows kexec to work as fast > as regular kernel boot, as well as adding this .shutdown pointer. > > Shutting a device prior to the shutdown completely is always > a good idea IMHO to help with kexec, > and this one-liner patch implements it. > > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com> > --- > drivers/thunderbolt/nhi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c > index 1be491ecbb45..4046642e6aec 100644 > --- a/drivers/thunderbolt/nhi.c > +++ b/drivers/thunderbolt/nhi.c > @@ -1285,6 +1285,7 @@ static struct pci_driver nhi_driver = { > .id_table = nhi_ids, > .probe = nhi_probe, > .remove = nhi_remove, > + .shutdown = nhi_remove, > .driver.pm = &nhi_pm_ops, > }; > Oops, I see that I posted this little fix on a wrong mailing list. I didn't update the script correctly. Sorry for the noise! Best regards, Maxim Levitsky
diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 1be491ecbb45..4046642e6aec 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -1285,6 +1285,7 @@ static struct pci_driver nhi_driver = { .id_table = nhi_ids, .probe = nhi_probe, .remove = nhi_remove, + .shutdown = nhi_remove, .driver.pm = &nhi_pm_ops, };
On my machine, a kexec with this driver loaded in the old kernel causes a very long delay on boot in the kexec'ed kernel, most likely due to unclean shutdown prior to that. Unloading thunderbolt driver prior to kexec allows kexec to work as fast as regular kernel boot, as well as adding this .shutdown pointer. Shutting a device prior to the shutdown completely is always a good idea IMHO to help with kexec, and this one-liner patch implements it. Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com> --- drivers/thunderbolt/nhi.c | 1 + 1 file changed, 1 insertion(+)