| Message ID | 20200818130424.20522-3-mhartmay@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: Add Protected VM support | expand |
On Tue, Aug 18, 2020 at 03:04:22PM +0200, Marc Hartmayer wrote: > This is necessary to keep architecture dependent code separate from > common code. > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> > --- > README.md | 3 ++- > scripts/common.bash | 8 ++++++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 48be206c6db1..24d4bdaaee0d 100644 > --- a/README.md > +++ b/README.md > @@ -134,7 +134,8 @@ all unit tests. > ## Directory structure > > .: configure script, top-level Makefile, and run_tests.sh > - ./scripts: helper scripts for building and running tests > + ./scripts: general architecture neutral helper scripts for building and running tests > + ./scripts/<ARCH>: architecture dependent helper scripts for building and running tests > ./lib: general architecture neutral services for the tests > ./lib/<ARCH>: architecture dependent services for the tests > ./<ARCH>: the sources of the tests and the created objects/images > diff --git a/scripts/common.bash b/scripts/common.bash > index 96655c9ffd1f..c7acdf14a835 100644 > --- a/scripts/common.bash > +++ b/scripts/common.bash > @@ -1,3 +1,4 @@ > +source config.mak > > function for_each_unittest() > { > @@ -52,3 +53,10 @@ function for_each_unittest() > fi > exec {fd}<&- > } > + > +# The current file has to be the only file sourcing the arch helper > +# file > +ARCH_FUNC=scripts/${ARCH}/func.bash > +if [ -f "${ARCH_FUNC}" ]; then > + source "${ARCH_FUNC}" > +fi > -- > 2.25.4 > Reviewed-by: Andrew Jones <drjones@redhat.com>
On Tue, 18 Aug 2020 15:04:22 +0200 Marc Hartmayer <mhartmay@linux.ibm.com> wrote: > This is necessary to keep architecture dependent code separate from > common code. > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> > --- > README.md | 3 ++- > scripts/common.bash | 8 ++++++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
On 18.08.20 15:04, Marc Hartmayer wrote: > This is necessary to keep architecture dependent code separate from > common code. > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> > --- > README.md | 3 ++- > scripts/common.bash | 8 ++++++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 48be206c6db1..24d4bdaaee0d 100644 > --- a/README.md > +++ b/README.md > @@ -134,7 +134,8 @@ all unit tests. > ## Directory structure > > .: configure script, top-level Makefile, and run_tests.sh > - ./scripts: helper scripts for building and running tests > + ./scripts: general architecture neutral helper scripts for building and running tests > + ./scripts/<ARCH>: architecture dependent helper scripts for building and running tests > ./lib: general architecture neutral services for the tests > ./lib/<ARCH>: architecture dependent services for the tests > ./<ARCH>: the sources of the tests and the created objects/images > diff --git a/scripts/common.bash b/scripts/common.bash > index 96655c9ffd1f..c7acdf14a835 100644 > --- a/scripts/common.bash > +++ b/scripts/common.bash > @@ -1,3 +1,4 @@ > +source config.mak > > function for_each_unittest() > { > @@ -52,3 +53,10 @@ function for_each_unittest() > fi > exec {fd}<&- > } > + > +# The current file has to be the only file sourcing the arch helper > +# file > +ARCH_FUNC=scripts/${ARCH}/func.bash > +if [ -f "${ARCH_FUNC}" ]; then > + source "${ARCH_FUNC}" > +fi > Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/README.md b/README.md index 48be206c6db1..24d4bdaaee0d 100644 --- a/README.md +++ b/README.md @@ -134,7 +134,8 @@ all unit tests. ## Directory structure .: configure script, top-level Makefile, and run_tests.sh - ./scripts: helper scripts for building and running tests + ./scripts: general architecture neutral helper scripts for building and running tests + ./scripts/<ARCH>: architecture dependent helper scripts for building and running tests ./lib: general architecture neutral services for the tests ./lib/<ARCH>: architecture dependent services for the tests ./<ARCH>: the sources of the tests and the created objects/images diff --git a/scripts/common.bash b/scripts/common.bash index 96655c9ffd1f..c7acdf14a835 100644 --- a/scripts/common.bash +++ b/scripts/common.bash @@ -1,3 +1,4 @@ +source config.mak function for_each_unittest() { @@ -52,3 +53,10 @@ function for_each_unittest() fi exec {fd}<&- } + +# The current file has to be the only file sourcing the arch helper +# file +ARCH_FUNC=scripts/${ARCH}/func.bash +if [ -f "${ARCH_FUNC}" ]; then + source "${ARCH_FUNC}" +fi
This is necessary to keep architecture dependent code separate from common code. Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> --- README.md | 3 ++- scripts/common.bash | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-)