mbox

[kvm-unit-tests,PULL,00/11] s390x and generic script updates

Message ID 20200928174958.26690-1-thuth@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://gitlab.com/huth/kvm-unit-tests.git tags/pull-request-2020-09-28

Message

Thomas Huth Sept. 28, 2020, 5:49 p.m. UTC
Hi Paolo,

the following changes since commit 58c94d57a51a6927a68e3f09627b2d85e3404c0f:

  travis.yml: Use TRAVIS_BUILD_DIR to refer to the top directory (2020-09-25 10:00:36 +0200)

are available in the Git repository at:

  https://gitlab.com/huth/kvm-unit-tests.git tags/pull-request-2020-09-28

for you to fetch changes up to b508e1147055255ecce93a95916363bda8c8f299:

  scripts/arch-run: use ncat rather than nc. (2020-09-28 15:03:50 +0200)

----------------------------------------------------------------
- s390x protected VM support
- Some other small s390x improvements
- Generic improvements in the scripts (better TAP13 names, nc -> ncat, ...)
----------------------------------------------------------------

Jamie Iles (1):
      scripts/arch-run: use ncat rather than nc.

Marc Hartmayer (6):
      runtime.bash: remove outdated comment
      Use same test names in the default and the TAP13 output format
      common.bash: run `cmd` only if a test case was found
      scripts: add support for architecture dependent functions
      run_tests/mkstandalone: add arch_cmd hook
      s390x: add Protected VM support

Thomas Huth (4):
      configure: Add a check for the bash version
      travis.yml: Update from Bionic to Focal
      travis.yml: Update the list of s390x tests
      s390x/selftest: Fix constraint of inline assembly

 .travis.yml             |  7 ++++---
 README.md               |  3 ++-
 configure               | 14 ++++++++++++++
 run_tests.sh            | 18 +++++++++---------
 s390x/Makefile          | 15 ++++++++++++++-
 s390x/selftest.c        |  2 +-
 s390x/selftest.parmfile |  1 +
 s390x/unittests.cfg     |  1 +
 scripts/arch-run.bash   |  6 +++---
 scripts/common.bash     | 21 +++++++++++++++++++--
 scripts/mkstandalone.sh |  4 ----
 scripts/runtime.bash    |  9 +++------
 scripts/s390x/func.bash | 35 +++++++++++++++++++++++++++++++++++
 13 files changed, 106 insertions(+), 30 deletions(-)
 create mode 100644 s390x/selftest.parmfile
 create mode 100644 scripts/s390x/func.bash

Comments

Paolo Bonzini Sept. 29, 2020, 8:38 a.m. UTC | #1
On 28/09/20 19:49, Thomas Huth wrote:
>  Hi Paolo,
> 
> the following changes since commit 58c94d57a51a6927a68e3f09627b2d85e3404c0f:
> 
>   travis.yml: Use TRAVIS_BUILD_DIR to refer to the top directory (2020-09-25 10:00:36 +0200)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/huth/kvm-unit-tests.git tags/pull-request-2020-09-28
> 
> for you to fetch changes up to b508e1147055255ecce93a95916363bda8c8f299:
> 
>   scripts/arch-run: use ncat rather than nc. (2020-09-28 15:03:50 +0200)
> 
> ----------------------------------------------------------------
> - s390x protected VM support
> - Some other small s390x improvements
> - Generic improvements in the scripts (better TAP13 names, nc -> ncat, ...)
> ----------------------------------------------------------------
> 
> Jamie Iles (1):
>       scripts/arch-run: use ncat rather than nc.
> 
> Marc Hartmayer (6):
>       runtime.bash: remove outdated comment
>       Use same test names in the default and the TAP13 output format
>       common.bash: run `cmd` only if a test case was found
>       scripts: add support for architecture dependent functions
>       run_tests/mkstandalone: add arch_cmd hook
>       s390x: add Protected VM support
> 
> Thomas Huth (4):
>       configure: Add a check for the bash version
>       travis.yml: Update from Bionic to Focal
>       travis.yml: Update the list of s390x tests
>       s390x/selftest: Fix constraint of inline assembly
> 
>  .travis.yml             |  7 ++++---
>  README.md               |  3 ++-
>  configure               | 14 ++++++++++++++
>  run_tests.sh            | 18 +++++++++---------
>  s390x/Makefile          | 15 ++++++++++++++-
>  s390x/selftest.c        |  2 +-
>  s390x/selftest.parmfile |  1 +
>  s390x/unittests.cfg     |  1 +
>  scripts/arch-run.bash   |  6 +++---
>  scripts/common.bash     | 21 +++++++++++++++++++--
>  scripts/mkstandalone.sh |  4 ----
>  scripts/runtime.bash    |  9 +++------
>  scripts/s390x/func.bash | 35 +++++++++++++++++++++++++++++++++++
>  13 files changed, 106 insertions(+), 30 deletions(-)
>  create mode 100644 s390x/selftest.parmfile
>  create mode 100644 scripts/s390x/func.bash
> 

Pulled, thanks (for now to my clone; waiting for CI to complete).
Should we switch to Gitlab merge requests for pull requests only (i.e.
patches still go on the mailing list)?

Paolo
Thomas Huth Sept. 29, 2020, 8:47 a.m. UTC | #2
On 29/09/2020 10.38, Paolo Bonzini wrote:
> On 28/09/20 19:49, Thomas Huth wrote:
>>  Hi Paolo,
>>
>> the following changes since commit 58c94d57a51a6927a68e3f09627b2d85e3404c0f:
>>
>>   travis.yml: Use TRAVIS_BUILD_DIR to refer to the top directory (2020-09-25 10:00:36 +0200)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.com/huth/kvm-unit-tests.git tags/pull-request-2020-09-28
>>
>> for you to fetch changes up to b508e1147055255ecce93a95916363bda8c8f299:
>>
>>   scripts/arch-run: use ncat rather than nc. (2020-09-28 15:03:50 +0200)
[...]
> Pulled, thanks (for now to my clone; waiting for CI to complete).
> Should we switch to Gitlab merge requests for pull requests only (i.e.
> patches still go on the mailing list)?

Fine for me, though I'm not sure whether the other maintainers are
already using gitlab or not... And do we need e-mail notifications for
such merge requests sent to the mailing list, in case anybody else still
wants to object?

 Thomas
Janosch Frank Sept. 29, 2020, 8:49 a.m. UTC | #3
On 9/29/20 10:38 AM, Paolo Bonzini wrote:
> On 28/09/20 19:49, Thomas Huth wrote:
>>  Hi Paolo,
>>
>> the following changes since commit 58c94d57a51a6927a68e3f09627b2d85e3404c0f:
>>
>>   travis.yml: Use TRAVIS_BUILD_DIR to refer to the top directory (2020-09-25 10:00:36 +0200)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.com/huth/kvm-unit-tests.git tags/pull-request-2020-09-28
>>
>> for you to fetch changes up to b508e1147055255ecce93a95916363bda8c8f299:
>>
>>   scripts/arch-run: use ncat rather than nc. (2020-09-28 15:03:50 +0200)
>>
>> ----------------------------------------------------------------
>> - s390x protected VM support
>> - Some other small s390x improvements
>> - Generic improvements in the scripts (better TAP13 names, nc -> ncat, ...)
>> ----------------------------------------------------------------
>>
>> Jamie Iles (1):
>>       scripts/arch-run: use ncat rather than nc.
>>
>> Marc Hartmayer (6):
>>       runtime.bash: remove outdated comment
>>       Use same test names in the default and the TAP13 output format
>>       common.bash: run `cmd` only if a test case was found
>>       scripts: add support for architecture dependent functions
>>       run_tests/mkstandalone: add arch_cmd hook
>>       s390x: add Protected VM support
>>
>> Thomas Huth (4):
>>       configure: Add a check for the bash version
>>       travis.yml: Update from Bionic to Focal
>>       travis.yml: Update the list of s390x tests
>>       s390x/selftest: Fix constraint of inline assembly
>>
>>  .travis.yml             |  7 ++++---
>>  README.md               |  3 ++-
>>  configure               | 14 ++++++++++++++
>>  run_tests.sh            | 18 +++++++++---------
>>  s390x/Makefile          | 15 ++++++++++++++-
>>  s390x/selftest.c        |  2 +-
>>  s390x/selftest.parmfile |  1 +
>>  s390x/unittests.cfg     |  1 +
>>  scripts/arch-run.bash   |  6 +++---
>>  scripts/common.bash     | 21 +++++++++++++++++++--
>>  scripts/mkstandalone.sh |  4 ----
>>  scripts/runtime.bash    |  9 +++------
>>  scripts/s390x/func.bash | 35 +++++++++++++++++++++++++++++++++++
>>  13 files changed, 106 insertions(+), 30 deletions(-)
>>  create mode 100644 s390x/selftest.parmfile
>>  create mode 100644 scripts/s390x/func.bash
>>
> 
> Pulled, thanks (for now to my clone; waiting for CI to complete).
> Should we switch to Gitlab merge requests for pull requests only (i.e.
> patches still go on the mailing list)?
> 
> Paolo
> 

Hrm, that would force everyone to use Gitlab and I see some value in
having pull request mails on the lists. You just opened the Pandora's
box of discussions :-)

If it's easier for you I'd be open to open a marge request and send out
pull mails at the same time so people can comment without login to Gitlab.
Thomas Huth Sept. 29, 2020, 8:58 a.m. UTC | #4
On 29/09/2020 10.49, Janosch Frank wrote:
> On 9/29/20 10:38 AM, Paolo Bonzini wrote:
>> On 28/09/20 19:49, Thomas Huth wrote:
>>>  Hi Paolo,
>>>
>>> the following changes since commit 58c94d57a51a6927a68e3f09627b2d85e3404c0f:
>>>
>>>   travis.yml: Use TRAVIS_BUILD_DIR to refer to the top directory (2020-09-25 10:00:36 +0200)
>>>
>>> are available in the Git repository at:
>>>
>>>   https://gitlab.com/huth/kvm-unit-tests.git tags/pull-request-2020-09-28
>>>
>>> for you to fetch changes up to b508e1147055255ecce93a95916363bda8c8f299:
>>>
>>>   scripts/arch-run: use ncat rather than nc. (2020-09-28 15:03:50 +0200)
>>>
>>> ----------------------------------------------------------------
>>> - s390x protected VM support
>>> - Some other small s390x improvements
>>> - Generic improvements in the scripts (better TAP13 names, nc -> ncat, ...)
>>> ----------------------------------------------------------------
>>>
>>> Jamie Iles (1):
>>>       scripts/arch-run: use ncat rather than nc.
>>>
>>> Marc Hartmayer (6):
>>>       runtime.bash: remove outdated comment
>>>       Use same test names in the default and the TAP13 output format
>>>       common.bash: run `cmd` only if a test case was found
>>>       scripts: add support for architecture dependent functions
>>>       run_tests/mkstandalone: add arch_cmd hook
>>>       s390x: add Protected VM support
>>>
>>> Thomas Huth (4):
>>>       configure: Add a check for the bash version
>>>       travis.yml: Update from Bionic to Focal
>>>       travis.yml: Update the list of s390x tests
>>>       s390x/selftest: Fix constraint of inline assembly
>>>
>>>  .travis.yml             |  7 ++++---
>>>  README.md               |  3 ++-
>>>  configure               | 14 ++++++++++++++
>>>  run_tests.sh            | 18 +++++++++---------
>>>  s390x/Makefile          | 15 ++++++++++++++-
>>>  s390x/selftest.c        |  2 +-
>>>  s390x/selftest.parmfile |  1 +
>>>  s390x/unittests.cfg     |  1 +
>>>  scripts/arch-run.bash   |  6 +++---
>>>  scripts/common.bash     | 21 +++++++++++++++++++--
>>>  scripts/mkstandalone.sh |  4 ----
>>>  scripts/runtime.bash    |  9 +++------
>>>  scripts/s390x/func.bash | 35 +++++++++++++++++++++++++++++++++++
>>>  13 files changed, 106 insertions(+), 30 deletions(-)
>>>  create mode 100644 s390x/selftest.parmfile
>>>  create mode 100644 scripts/s390x/func.bash
>>>
>>
>> Pulled, thanks (for now to my clone; waiting for CI to complete).
>> Should we switch to Gitlab merge requests for pull requests only (i.e.
>> patches still go on the mailing list)?
>>
>> Paolo
>>
> 
> Hrm, that would force everyone to use Gitlab and I see some value in
> having pull request mails on the lists. You just opened the Pandora's
> box of discussions :-)
> 
> If it's easier for you I'd be open to open a marge request and send out
> pull mails at the same time so people can comment without login to Gitlab.

... or maybe the people who already have a gitlab account could simply
include the URL to their CI run in their pull request cover letter...?

 Thomas
Paolo Bonzini Sept. 29, 2020, 9:06 a.m. UTC | #5
On 29/09/20 10:58, Thomas Huth wrote:
>> Hrm, that would force everyone to use Gitlab and I see some value in
>> having pull request mails on the lists. You just opened the Pandora's
>> box of discussions :-)

That was the point. :)  It was more to see opinions and alternative
ideas than to seriously propose it.

>> If it's easier for you I'd be open to open a marge request and send out
>> pull mails at the same time so people can comment without login to Gitlab.
>
> ... or maybe the people who already have a gitlab account could simply
> include the URL to their CI run in their pull request cover letter...?

That's a good idea!

Paolo
Paolo Bonzini Oct. 1, 2020, 9:21 a.m. UTC | #6
On 28/09/20 19:49, Thomas Huth wrote:
>  Hi Paolo,
> 
> the following changes since commit 58c94d57a51a6927a68e3f09627b2d85e3404c0f:
> 
>   travis.yml: Use TRAVIS_BUILD_DIR to refer to the top directory (2020-09-25 10:00:36 +0200)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/huth/kvm-unit-tests.git tags/pull-request-2020-09-28
> 
> for you to fetch changes up to b508e1147055255ecce93a95916363bda8c8f299:
> 
>   scripts/arch-run: use ncat rather than nc. (2020-09-28 15:03:50 +0200)
> 
> ----------------------------------------------------------------
> - s390x protected VM support
> - Some other small s390x improvements
> - Generic improvements in the scripts (better TAP13 names, nc -> ncat, ...)
> ----------------------------------------------------------------
> 
> Jamie Iles (1):
>       scripts/arch-run: use ncat rather than nc.
> 
> Marc Hartmayer (6):
>       runtime.bash: remove outdated comment
>       Use same test names in the default and the TAP13 output format
>       common.bash: run `cmd` only if a test case was found
>       scripts: add support for architecture dependent functions
>       run_tests/mkstandalone: add arch_cmd hook
>       s390x: add Protected VM support
> 
> Thomas Huth (4):
>       configure: Add a check for the bash version
>       travis.yml: Update from Bionic to Focal
>       travis.yml: Update the list of s390x tests
>       s390x/selftest: Fix constraint of inline assembly
> 
>  .travis.yml             |  7 ++++---
>  README.md               |  3 ++-
>  configure               | 14 ++++++++++++++
>  run_tests.sh            | 18 +++++++++---------
>  s390x/Makefile          | 15 ++++++++++++++-
>  s390x/selftest.c        |  2 +-
>  s390x/selftest.parmfile |  1 +
>  s390x/unittests.cfg     |  1 +
>  scripts/arch-run.bash   |  6 +++---
>  scripts/common.bash     | 21 +++++++++++++++++++--
>  scripts/mkstandalone.sh |  4 ----
>  scripts/runtime.bash    |  9 +++------
>  scripts/s390x/func.bash | 35 +++++++++++++++++++++++++++++++++++
>  13 files changed, 106 insertions(+), 30 deletions(-)
>  create mode 100644 s390x/selftest.parmfile
>  create mode 100644 scripts/s390x/func.bash
> 

Pulled, thanks.

Paolo