| Message ID | 20210114003708.3798992-11-seanjc@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: SVM: Misc SEV cleanups | expand |
On 1/13/21 6:37 PM, Sean Christopherson wrote: > Query max_sev_asid directly after setting it instead of bouncing through > its wrapper, svm_sev_enabled(). Using the wrapper is unnecessary > obfuscation. > > No functional change intended. > > Signed-off-by: Sean Christopherson <seanjc@google.com> > --- > arch/x86/kvm/svm/sev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) thanks Reviewed-by: Brijesh Singh <brijesh.singh@amd.com> > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 02a66008e9b9..1a143340103e 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -1278,8 +1278,7 @@ void __init sev_hardware_setup(void) > > /* Maximum number of encrypted guests supported simultaneously */ > max_sev_asid = ecx; > - > - if (!svm_sev_enabled()) > + if (!max_sev_asid) > goto out; > > /* Minimum ASID value that should be used for SEV guest */
On 1/13/21 6:37 PM, Sean Christopherson wrote: > Query max_sev_asid directly after setting it instead of bouncing through > its wrapper, svm_sev_enabled(). Using the wrapper is unnecessary > obfuscation. > > No functional change intended. > > Signed-off-by: Sean Christopherson <seanjc@google.com> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com> > --- > arch/x86/kvm/svm/sev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 02a66008e9b9..1a143340103e 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -1278,8 +1278,7 @@ void __init sev_hardware_setup(void) > > /* Maximum number of encrypted guests supported simultaneously */ > max_sev_asid = ecx; > - > - if (!svm_sev_enabled()) > + if (!max_sev_asid) > goto out; > > /* Minimum ASID value that should be used for SEV guest */ >
diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 02a66008e9b9..1a143340103e 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -1278,8 +1278,7 @@ void __init sev_hardware_setup(void) /* Maximum number of encrypted guests supported simultaneously */ max_sev_asid = ecx; - - if (!svm_sev_enabled()) + if (!max_sev_asid) goto out; /* Minimum ASID value that should be used for SEV guest */
Query max_sev_asid directly after setting it instead of bouncing through its wrapper, svm_sev_enabled(). Using the wrapper is unnecessary obfuscation. No functional change intended. Signed-off-by: Sean Christopherson <seanjc@google.com> --- arch/x86/kvm/svm/sev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)