| Message ID | 20220311002528.2230172-3-dmatlack@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Extend Eager Page Splitting to the shadow MMU | expand |
On Fri, Mar 11, 2022 at 12:25:04AM +0000, David Matlack wrote: > The parameter "direct" can either be true or false, and all of the > callers pass in a bool variable or true/false literal, so just use the > type bool. > > No functional change intended. > > Signed-off-by: David Matlack <dmatlack@google.com> If we care about this.. how about convert another one altogether? TRACE_EVENT(kvm_hv_stimer_expiration, TP_PROTO(int vcpu_id, int timer_index, int direct, int msg_send_result), TP_ARGS(vcpu_id, timer_index, direct, msg_send_result), Thanks,
On Tue, Mar 15, 2022 at 12:46 AM Peter Xu <peterx@redhat.com> wrote: > > On Fri, Mar 11, 2022 at 12:25:04AM +0000, David Matlack wrote: > > The parameter "direct" can either be true or false, and all of the > > callers pass in a bool variable or true/false literal, so just use the > > type bool. > > > > No functional change intended. > > > > Signed-off-by: David Matlack <dmatlack@google.com> > > If we care about this.. how about convert another one altogether? > > TRACE_EVENT(kvm_hv_stimer_expiration, > TP_PROTO(int vcpu_id, int timer_index, int direct, int msg_send_result), > TP_ARGS(vcpu_id, timer_index, direct, msg_send_result), My preference would be to keep this commit specific to uses of "direct" that are related to shadow pages. The parameter `direct` in trace_kvm_hv_stimer_expiration() looks like it could be converted as well, but is a different concept altogether despite having the same variable name. > > Thanks, > > -- > Peter Xu >
diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 3ad67f70e51c..146df73a982e 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -1706,7 +1706,7 @@ static void drop_parent_pte(struct kvm_mmu_page *sp, mmu_spte_clear_no_track(parent_pte); } -static struct kvm_mmu_page *kvm_mmu_alloc_page(struct kvm_vcpu *vcpu, int direct) +static struct kvm_mmu_page *kvm_mmu_alloc_page(struct kvm_vcpu *vcpu, bool direct) { struct kvm_mmu_page *sp; @@ -2031,7 +2031,7 @@ static struct kvm_mmu_page *kvm_mmu_get_page(struct kvm_vcpu *vcpu, gfn_t gfn, gva_t gaddr, unsigned level, - int direct, + bool direct, unsigned int access) { union kvm_mmu_page_role role;
The parameter "direct" can either be true or false, and all of the callers pass in a bool variable or true/false literal, so just use the type bool. No functional change intended. Signed-off-by: David Matlack <dmatlack@google.com> --- arch/x86/kvm/mmu/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)