diff mbox series

[kvm-unit-tests,2/5] s390x: snippets: Fix SET_PSW_NEW_ADDR macro

Message ID 20221123084656.19864-3-frankja@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series s390x: Snippet fixes | expand

Commit Message

Janosch Frank Nov. 23, 2022, 8:46 a.m. UTC
Let's store the psw mask instead of the address of the location where we
should load the mask from.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 s390x/snippets/asm/macros.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nico Boehr Nov. 23, 2022, 10:58 a.m. UTC | #1
Quoting Janosch Frank (2022-11-23 09:46:53)
> Let's store the psw mask instead of the address of the location where we
> should load the mask from.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
Claudio Imbrenda Nov. 23, 2022, 1:05 p.m. UTC | #2
On Wed, 23 Nov 2022 08:46:53 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> Let's store the psw mask instead of the address of the location where we
> should load the mask from.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  s390x/snippets/asm/macros.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/s390x/snippets/asm/macros.S b/s390x/snippets/asm/macros.S
> index 667fb6dc..09d7f5be 100644
> --- a/s390x/snippets/asm/macros.S
> +++ b/s390x/snippets/asm/macros.S
> @@ -18,7 +18,7 @@
>   */
>  .macro SET_PSW_NEW_ADDR reg, psw_new_addr, addr_psw
>  larl	\reg, psw_mask_64
> -stg	\reg, \addr_psw
> +mvc	\addr_psw(8,%r0), 0(\reg)
>  larl	\reg, \psw_new_addr
>  stg	\reg, \addr_psw + 8
>  .endm
diff mbox series

Patch

diff --git a/s390x/snippets/asm/macros.S b/s390x/snippets/asm/macros.S
index 667fb6dc..09d7f5be 100644
--- a/s390x/snippets/asm/macros.S
+++ b/s390x/snippets/asm/macros.S
@@ -18,7 +18,7 @@ 
  */
 .macro SET_PSW_NEW_ADDR reg, psw_new_addr, addr_psw
 larl	\reg, psw_mask_64
-stg	\reg, \addr_psw
+mvc	\addr_psw(8,%r0), 0(\reg)
 larl	\reg, \psw_new_addr
 stg	\reg, \addr_psw + 8
 .endm