| Message ID | 20230104175950.731988-1-nsg@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests,v1] s390x: Fix integer literal in skey.c | expand |
I forgot:
Fixes: 965e38a0 ("s390x: Test effect of storage keys on diag 308")
On Wed, 2023-01-04 at 18:59 +0100, Nina Schoetterl-Glausch wrote:
> The code is a 64bit number of which the upper 48 bits must be 0.
>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> ---
> s390x/skey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/skey.c b/s390x/skey.c
> index 1167e4d3..7c7a8090 100644
> --- a/s390x/skey.c
> +++ b/s390x/skey.c
> @@ -320,7 +320,7 @@ static void test_diag_308(void)
> "lr %[response],%%r3\n"
> : [response] "=d" (response)
> : [ipib] "d" (ipib),
> - [code] "d" (5)
> + [code] "d" (5L)
> : "%r2", "%r3"
> );
> report(response == 0x402, "no exception on fetch, response: invalid IPIB");
>
> base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea
On 04/01/2023 18.59, Nina Schoetterl-Glausch wrote: > The code is a 64bit number of which the upper 48 bits must be 0. > > Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com> > --- > s390x/skey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/s390x/skey.c b/s390x/skey.c > index 1167e4d3..7c7a8090 100644 > --- a/s390x/skey.c > +++ b/s390x/skey.c > @@ -320,7 +320,7 @@ static void test_diag_308(void) > "lr %[response],%%r3\n" > : [response] "=d" (response) > : [ipib] "d" (ipib), > - [code] "d" (5) > + [code] "d" (5L) > : "%r2", "%r3" > ); > report(response == 0x402, "no exception on fetch, response: invalid IPIB"); > > base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea Thanks, I've pushed it directly as a trivial fix. Thomas
diff --git a/s390x/skey.c b/s390x/skey.c index 1167e4d3..7c7a8090 100644 --- a/s390x/skey.c +++ b/s390x/skey.c @@ -320,7 +320,7 @@ static void test_diag_308(void) "lr %[response],%%r3\n" : [response] "=d" (response) : [ipib] "d" (ipib), - [code] "d" (5) + [code] "d" (5L) : "%r2", "%r3" ); report(response == 0x402, "no exception on fetch, response: invalid IPIB");
The code is a 64bit number of which the upper 48 bits must be 0. Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com> --- s390x/skey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 73d9d850f1c2c9f0df321967e67acda0d2c305ea