| Message ID | 20230107034721.2127-1-angus.chen@jaguarmicro.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio: platform: No need to check res again | expand |
Hi, On 1/7/23 04:47, Angus Chen wrote: > In function vfio_platform_regions_init(),we did check res implied > by using while loop, > so no need to check whether res be null or not again. > > No functional change intended. > > Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric > --- > drivers/vfio/platform/vfio_platform_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c > index 1a0a238ffa35..a9ad3f4d2613 100644 > --- a/drivers/vfio/platform/vfio_platform_common.c > +++ b/drivers/vfio/platform/vfio_platform_common.c > @@ -150,9 +150,6 @@ static int vfio_platform_regions_init(struct vfio_platform_device *vdev) > struct resource *res = > vdev->get_resource(vdev, i); > > - if (!res) > - goto err; > - > vdev->regions[i].addr = res->start; > vdev->regions[i].size = resource_size(res); > vdev->regions[i].flags = 0;
On Sat, 7 Jan 2023 11:47:20 +0800 Angus Chen <angus.chen@jaguarmicro.com> wrote: > In function vfio_platform_regions_init(),we did check res implied > by using while loop, > so no need to check whether res be null or not again. > > No functional change intended. > > Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com> > --- > drivers/vfio/platform/vfio_platform_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c > index 1a0a238ffa35..a9ad3f4d2613 100644 > --- a/drivers/vfio/platform/vfio_platform_common.c > +++ b/drivers/vfio/platform/vfio_platform_common.c > @@ -150,9 +150,6 @@ static int vfio_platform_regions_init(struct vfio_platform_device *vdev) > struct resource *res = > vdev->get_resource(vdev, i); > > - if (!res) > - goto err; > - > vdev->regions[i].addr = res->start; > vdev->regions[i].size = resource_size(res); > vdev->regions[i].flags = 0; Applied to vfio next branch for v6.3. Thanks, Alex
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c index 1a0a238ffa35..a9ad3f4d2613 100644 --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -150,9 +150,6 @@ static int vfio_platform_regions_init(struct vfio_platform_device *vdev) struct resource *res = vdev->get_resource(vdev, i); - if (!res) - goto err; - vdev->regions[i].addr = res->start; vdev->regions[i].size = resource_size(res); vdev->regions[i].flags = 0;
In function vfio_platform_regions_init(),we did check res implied by using while loop, so no need to check whether res be null or not again. No functional change intended. Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com> --- drivers/vfio/platform/vfio_platform_common.c | 3 --- 1 file changed, 3 deletions(-)